Source/core/rendering/RenderTableSection.h - Issue 398013005: ASSERTION FAILED: !extraRowSpanningHeight in WebCore::RenderTableSection::distributeRowSpanHeightTo…

Side by Side Diff: Source/core/rendering/RenderTableSection.h

Issue 398013005: ASSERTION FAILED: !extraRowSpanningHeight in WebCore::RenderTableSection::distributeRowSpanHeightTo… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/table/table-rowspan-crash-only-percent-rows-with-less-than-100-percent-expected.txt ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)	2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)

3 * (C) 1997 Torben Weis (weis@kde.org)	3 * (C) 1997 Torben Weis (weis@kde.org)

4 * (C) 1998 Waldo Bastian (bastian@kde.org)	4 * (C) 1998 Waldo Bastian (bastian@kde.org)

5 * (C) 1999 Lars Knoll (knoll@kde.org)	5 * (C) 1999 Lars Knoll (knoll@kde.org)

6 * (C) 1999 Antti Koivisto (koivisto@kde.org)	6 * (C) 1999 Antti Koivisto (koivisto@kde.org)

7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed.	7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed.

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 238 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
249	249

250 void ensureRows(unsigned);	250 void ensureRows(unsigned);

251	251

252 bool rowHasOnlySpanningCells(unsigned);	252 bool rowHasOnlySpanningCells(unsigned);

253 unsigned calcRowHeightHavingOnlySpanningCells(unsigned);	253 unsigned calcRowHeightHavingOnlySpanningCells(unsigned);

254 void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct Spanni ngRowsHeight&);	254 void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct Spanni ngRowsHeight&);

255 bool isHeightNeededForRowHavingOnlySpanningCells(unsigned);	255 bool isHeightNeededForRowHavingOnlySpanningCells(unsigned);

256	256

257 void populateSpanningRowsHeightFromCell(RenderTableCell*, struct SpanningRow sHeight&);	257 void populateSpanningRowsHeightFromCell(RenderTableCell*, struct SpanningRow sHeight&);

258 void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int&, Vector<int>&);	258 void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int&, Vector<int>&);

	259 void distributeWholeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, i nt&, Vector<int>&);

259 void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vec tor<int>&);	260 void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vec tor<int>&);

260 void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int& , Vector<int>&);	261 void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int& , Vector<int>&);

261 void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells);	262 void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells);

262	263

263 void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent);	264 void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent);

264 void distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigne d autoRowsCount);	265 void distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigne d autoRowsCount);

265 void distributeRemainingExtraLogicalHeight(int& extraLogicalHeight);	266 void distributeRemainingExtraLogicalHeight(int& extraLogicalHeight);

266	267

267 void updateBaselineForCell(RenderTableCell*, unsigned row, LayoutUnit& basel ineDescent);	268 void updateBaselineForCell(RenderTableCell*, unsigned row, LayoutUnit& basel ineDescent);

268	269

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
325 static const bool needsDestruction = false;	326 static const bool needsDestruction = false;

326 };	327 };

327 template<> struct VectorTraits<blink::RenderTableSection::RowStruct> : VectorTra itsBase<blink::RenderTableSection::RowStruct> {	328 template<> struct VectorTraits<blink::RenderTableSection::RowStruct> : VectorTra itsBase<blink::RenderTableSection::RowStruct> {

328 static const bool needsDestruction = false;	329 static const bool needsDestruction = false;

329 };	330 };

330 #endif	331 #endif

331	332

332 }	333 }

333	334

334 #endif // RenderTableSection_h	335 #endif // RenderTableSection_h

OLD	NEW