ASSERTION FAILED: !extraRowSpanningHeight in WebCore::RenderTableSection::distributeRowSpanHeightTo…

ASSERTION FAILED: !extraRowSpanningHeight in WebCore::RenderTableSection::distributeRowSpanHeightToRows

Spanning rows have only percent rows and total percent is less than 100 So only
percent portion of extraRowSpnnaingHeight is consumed in percent spanning rows and
remaining is left to distribute in non-spanning rows. But non-percent rows height
is zero So assertion is failing.

Now, whole extraRowSpanningHeight is distributed to percent spanning rows if non-percent
spanning rows height is zero.

R=jchaffraix@chromium.org
BUG=366579
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180417

[suchit.agrawal, 2014-07-21 14:14:14]

On 2014/07/21 13:15:46, a.suchit2 wrote:

Tomorrow, I will add a test case for it.

Please review it. Thanks

[suchit.agrawal, 2014-07-25 01:13:07]

On 2014/07/21 14:14:14, suchit.agrawal wrote:
> On 2014/07/21 13:15:46, a.suchit2 wrote:
> 
> Tomorrow, I will add a test case for it.
> 
> Please review it. Thanks

[suchit.agrawal, 2014-07-25 01:13:07]

On 2014/07/21 14:14:14, suchit.agrawal wrote:
> On 2014/07/21 13:15:46, a.suchit2 wrote:
> 
> Tomorrow, I will add a test case for it.
> 
> Please review it. Thanks

[suchit.agrawal, 2014-07-25 01:17:18]

On 2014/07/25 01:13:07, suchit.agrawal wrote:
> On 2014/07/21 14:14:14, suchit.agrawal wrote:
> > On 2014/07/21 13:15:46, a.suchit2 wrote:
> > 
> > Tomorrow, I will add a test case for it.
> > 
> > Please review it. Thanks

Please review this patch.
Thanks

[suchit.agrawal, 2014-07-25 19:06:39]

On 2014/07/25 01:17:18, suchit.agrawal wrote:
> On 2014/07/25 01:13:07, suchit.agrawal wrote:
> > On 2014/07/21 14:14:14, suchit.agrawal wrote:
> > > On 2014/07/21 13:15:46, a.suchit2 wrote:
> > > 
> > > Tomorrow, I will add a test case for it.
> > > 
> > > Please review it. Thanks
> 
> Please review this patch.
> Thanks

Please review it.

[a.suchit, 2014-07-28 11:45:54]

The CQ bit was checked by a.suchit@samsung.com

[a.suchit, 2014-07-28 11:45:55]

The CQ bit was unchecked by a.suchit@samsung.com

[suchit.agrawal, 2014-07-28 19:36:15]

On 2014/07/28 11:45:55, a.suchit wrote:
> The CQ bit was unchecked by mailto:a.suchit@samsung.com

Hi julien
Please review this issue.
Thanks

[suchit.agrawal, 2014-08-12 00:00:57]

On 2014/07/28 19:36:15, suchit.agrawal wrote:
> On 2014/07/28 11:45:55, a.suchit wrote:
> > The CQ bit was unchecked by mailto:a.suchit@samsung.com
> 
> Hi julien
> Please review this issue.
> Thanks

Please review it. Thanks

[a.suchit, 2014-08-14 23:51:18]

On 2014/08/12 00:00:57, suchit.agrawal wrote:
> On 2014/07/28 19:36:15, suchit.agrawal wrote:
> > On 2014/07/28 11:45:55, a.suchit wrote:
> > > The CQ bit was unchecked by mailto:a.suchit@samsung.com
> > 
> > Hi julien
> > Please review this issue.
> > Thanks
> 
> Please review it. Thanks

Please review. Thanks

[Julien - ping for review, 2014-08-15 20:17:09]

lgtm

https://codereview.chromium.org/398013005/diff/80001/Source/core/rendering/Re...
File Source/core/rendering/RenderTableSection.cpp (right):

https://codereview.chromium.org/398013005/diff/80001/Source/core/rendering/Re...
Source/core/rendering/RenderTableSection.cpp:377:
updatePositionIncreasedWithRowHeight(extraRowSpanningHeight,
m_grid[row].logicalHeight.percent(), totalPercent, accumulatedPositionIncrease,
remainder);
distributeExtraRowSpanHeightToPercentRows doesn't use this helper function. We
probably want to convert it too (as part of this change or in a follow-up).

[suchit.agrawal, 2014-08-17 07:16:22]

https://codereview.chromium.org/398013005/diff/80001/Source/core/rendering/Re...
File Source/core/rendering/RenderTableSection.cpp (right):

https://codereview.chromium.org/398013005/diff/80001/Source/core/rendering/Re...
Source/core/rendering/RenderTableSection.cpp:377:
updatePositionIncreasedWithRowHeight(extraRowSpanningHeight,
m_grid[row].logicalHeight.percent(), totalPercent, accumulatedPositionIncrease,
remainder);
On 2014/08/15 20:17:09, Julien Chaffraix - PST wrote:
> distributeExtraRowSpanHeightToPercentRows doesn't use this helper function. We
> probably want to convert it too (as part of this change or in a follow-up).

Acknowledged.

[a.suchit2, 2014-08-17 07:17:32]

The CQ bit was checked by a.suchit@chromium.org

[commit-bot: I haz the power, 2014-08-17 07:18:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/a.suchit@samsung.com/398013005/80001

[commit-bot: I haz the power, 2014-08-17 07:53:03]

Committed patchset #5 (80001) as 180417