Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 398013004: [CSS Grid Layout] Small refactoring in grid-auto-flow-get-set.html test (Closed)

Created:
6 years, 5 months ago by Manuel Rego
Modified:
6 years, 5 months ago
CC:
blink-reviews, jfernandez, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Small refactoring in grid-auto-flow-get-set.html test Add new helper methods to grid-definitions-parsing-utils.js and use them in grid-auto-flow-get-set.html. This will ease future modifications of this test. This has been done in WebKit as part of r171183: http://trac.webkit.org/changeset/171183 BUG=384099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178740

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -130 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set.html View 1 chunk +45 lines, -125 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-auto-flow-get-set-expected.txt View 3 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js View 1 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Manuel Rego
6 years, 5 months ago (2014-07-21 19:53:56 UTC) #1
svillar
On 2014/07/21 19:53:56, Manuel Rego wrote: Informal lgtm
6 years, 5 months ago (2014-07-22 08:53:51 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/398013004/diff/1/LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js File LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js (right): https://codereview.chromium.org/398013004/diff/1/LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js#newcode49 LayoutTests/fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:49: function checkGridAutoFlowSetCSSValue(elementId, expectedValue) { Blink style puts the ...
6 years, 5 months ago (2014-07-22 17:44:13 UTC) #3
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 5 months ago (2014-07-22 20:28:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/398013004/20001
6 years, 5 months ago (2014-07-22 20:29:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 23:59:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 01:59:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31150)
6 years, 5 months ago (2014-07-23 01:59:20 UTC) #8
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 5 months ago (2014-07-23 07:18:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/398013004/20001
6 years, 5 months ago (2014-07-23 07:19:08 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 07:19:52 UTC) #11
Message was sent while issue was closed.
Change committed as 178740

Powered by Google App Engine
This is Rietveld 408576698