Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: tools/telemetry/telemetry/core/forwarders/android_forwarder.py

Issue 398003007: [Telemetry] Android forwarder bug fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for iptable rules and getprop calls Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/forwarders/android_forwarder.py
diff --git a/tools/telemetry/telemetry/core/forwarders/android_forwarder.py b/tools/telemetry/telemetry/core/forwarders/android_forwarder.py
index 2cbcb28f08ad59a16a5a53d33e08f4aa191c4193..eb56079e4fff2a54c14fdc41cd76f2ffec8fad32 100644
--- a/tools/telemetry/telemetry/core/forwarders/android_forwarder.py
+++ b/tools/telemetry/telemetry/core/forwarders/android_forwarder.py
@@ -95,8 +95,8 @@ class AndroidRndisForwarder(forwarders.Forwarder):
protocol = 'udp' if port_pair.remote_port == 53 else 'tcp'
self._adb.RunShellCommand(
'iptables -t nat -A OUTPUT -p %s --dport %d'
- ' -j DNAT --to-destination :%d' %
- (protocol, port_pair.remote_port, port_pair.local_port))
+ ' -j DNAT --to-destination %s:%d' %
+ (protocol, port_pair.remote_port, self.host_ip, port_pair.local_port))
def _OverrideDns(self):
"""Overrides DNS on device to point at the host."""
@@ -121,7 +121,7 @@ class AndroidRndisForwarder(forwarders.Forwarder):
# TODO(szym): run via su -c if necessary.
self._adb.device().SetProp('net.dns1', dns1)
self._adb.device().SetProp('net.dns2', dns2)
- dnschange = self._adb.device.GetProp('net.dnschange')
+ dnschange = self._adb.device().GetProp('net.dnschange')
if dnschange:
self._adb.device().SetProp('net.dnschange', int(dnschange) + 1)
# Since commit 8b47b3601f82f299bb8c135af0639b72b67230e6 to frameworks/base
@@ -138,8 +138,8 @@ class AndroidRndisForwarder(forwarders.Forwarder):
default_routes = [route[0] for route in routes if route[1] == '00000000']
return (
default_routes[0] if default_routes else None,
- self._adb.GetProp('net.dns1'),
- self._adb.GetProp('net.dns2'),
+ self._adb.device().GetProp('net.dns1'),
+ self._adb.device().GetProp('net.dns2'),
)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698