Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 398003004: Remove yet-unused 64-bit atomic hooks. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove yet-unused 64-bit atomic hooks. For now, I think we'll just be using sk_atomic_inc on 64-bit values, so let's cut out the dead code for now. NOTREECHECKS=true BUG=skia: R=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/e7fd6db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M include/core/SkThread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ports/SkAtomics_sync.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/ports/SkAtomics_win.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 5 months ago (2014-07-16 19:10:53 UTC) #1
bsalomon
lgtm
6 years, 5 months ago (2014-07-16 19:12:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/398003004/1
6 years, 5 months ago (2014-07-16 19:12:49 UTC) #3
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-16 19:14:23 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-16 19:14:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/398003004/1
6 years, 5 months ago (2014-07-16 19:15:06 UTC) #6
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-16 19:20:41 UTC) #7
mtklein_C
6 years, 5 months ago (2014-07-16 19:21:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as re7fd6db.

Powered by Google App Engine
This is Rietveld 408576698