Issue 397993002: [WIP]Incorrect context menu is shown for tel: links

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397993002: [WIP]Incorrect context menu is shown for tel: links

Created:
6 years, 5 months ago by wajahat

Modified:
6 years, 5 months ago

Reviewers:
Yaron, Abhishek, Jitu( very slow this week)

CC:
chromium-reviews, Bernhard Bauer

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[WIP]Incorrect context menu is shown for tel: links When longpressed on tel: links context menu shows options irrelavant to tel scheme Context Menu should be displayed with the options as per the tel scheme possibly options can be: 1) Call 2) Send text message 3) Add to contacts 4) Copy phone number BUG=394299

Patch Set 1 #

Patch Set 2 : minor cleanup #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -4 lines)			Patch
M	chrome/android/java/res/menu/chrome_context_menu.xml	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItemDelegate.java	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java	View	1	6 chunks	+25 lines, -2 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/contextmenu/EmptyChromeContextMenuItemDelegate.java	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/android/java/strings/android_chrome_strings.grd	View		1 chunk	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wajahat

PTAL! This is work in progress patch changes can only move forward after similar issue ...

6 years, 5 months ago (2014-07-16 11:47:40 UTC) #1

wajahat

yfriedman@chromium.org: Please review changes in this patch

6 years, 5 months ago (2014-07-16 11:57:11 UTC) #2

Yaron

6 years, 5 months ago (2014-07-16 16:56:53 UTC) #3

On 2014/07/16 11:57:11, wajahat wrote:
> mailto:yfriedman@chromium.org: Please review changes in this patch

Given that this is blocked on another patch and that one still needs input from
product, I'm going to wait to review until this is closer to being landable

Expand Messages | Collapse Messages