src/bootstrapper.cc - Issue 397953009: Bootstrapper::DetachGlobal also need to unset global_proxy's constructor to remove all refs to cont…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 397953009: Bootstrapper::DetachGlobal also need to unset global_proxy's constructor to remove all refs to cont… (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: modify copied map Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index aaa0f3f7e521d4bf63263d48e658a8649ce7e429..0dfe3a3f7a4024f8d47b4b4162f821491f951833 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -355,6 +355,7 @@ void Bootstrapper::DetachGlobal(Handle<Context> env) {

Handle<JSGlobalProxy> global_proxy(JSGlobalProxy::cast(env->global_proxy()));

global_proxy->set_native_context(*factory->null_value());

SetObjectPrototype(global_proxy, factory->null_value());

+ global_proxy->map()->set_constructor(*factory->null_value());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »