Issue 397953007: Fold DecryptingDemuxerStream::Stop() into the dtor.

Issue 397953007: Fold DecryptingDemuxerStream::Stop() into the dtor. (Closed)

Created:
6 years, 5 months ago by xhwang

Modified:
6 years, 5 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fold DecryptingDemuxerStream::Stop() into the dtor. BUG=349211 TEST=Existing tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283886

Patch Set 2 : comments addressed #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -115 lines)			Patch
M	media/filters/audio_decoder_selector_unittest.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	media/filters/decoder_selector.cc	View	1	1 chunk	+4 lines, -22 lines	0 comments	Download
M	media/filters/decoder_stream.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	media/filters/decrypting_demuxer_stream.h	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	media/filters/decrypting_demuxer_stream.cc	View		3 chunks	+18 lines, -30 lines	0 comments	Download
M	media/filters/decrypting_demuxer_stream_unittest.cc	View	1	11 chunks	+33 lines, -46 lines	0 comments	Download
M	media/filters/video_decoder_selector_unittest.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

lgtm w/ nits https://codereview.chromium.org/397953007/diff/1/media/filters/decoder_selector.cc File media/filters/decoder_selector.cc (right): https://codereview.chromium.org/397953007/diff/1/media/filters/decoder_selector.cc#newcode119 media/filters/decoder_selector.cc:119: // We could be trying to ...

6 years, 5 months ago (2014-07-17 02:23:05 UTC) #2

xhwang

https://codereview.chromium.org/397953007/diff/1/media/filters/decoder_selector.cc File media/filters/decoder_selector.cc (right): https://codereview.chromium.org/397953007/diff/1/media/filters/decoder_selector.cc#newcode119 media/filters/decoder_selector.cc:119: // We could be trying to initialize the |decoder_| ...

6 years, 5 months ago (2014-07-17 05:00:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/397953007/20001

6 years, 5 months ago (2014-07-17 15:48:57 UTC) #6

Message was sent while issue was closed.

Change committed as 283886

Expand Messages | Collapse Messages