Issue 397953005: Add more components to the GN build.

Issue 397953005: Add more components to the GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add more components to the GN build. google infobars invalidation navigation_intercaption network_time password_manager plugins search_provider_logos sessions R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283521

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : merge, android fix #

Patch Set 4 : android fix #

Total comments: 2

Patch Set 5 : less android #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+510 lines, -23 lines)			Patch
M	components/BUILD.gn	View	1 2 3 4	3 chunks	+25 lines, -2 lines	0 comments	Download
M	components/google.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	components/google/core/browser/BUILD.gn	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	components/infobars.gypi	View		4 chunks	+5 lines, -1 line	0 comments	Download
A	components/infobars/core/BUILD.gn	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A +	components/infobars/test/BUILD.gn	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	components/invalidation.gypi	View		6 chunks	+6 lines, -0 lines	0 comments	Download
A	components/invalidation/BUILD.gn	View		1 chunk	+101 lines, -0 lines	0 comments	Download
M	components/navigation_interception.gypi	View		4 chunks	+5 lines, -0 lines	0 comments	Download
A	components/navigation_interception/BUILD.gn	View	1 2 3	1 chunk	+48 lines, -0 lines	0 comments	Download
M	components/network_time.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A +	components/network_time/BUILD.gn	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	components/password_manager.gypi	View		9 chunks	+9 lines, -0 lines	0 comments	Download
A	components/password_manager/content/browser/BUILD.gn	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	components/password_manager/core/browser/BUILD.gn	View		1 chunk	+109 lines, -0 lines	0 comments	Download
A +	components/password_manager/core/common/BUILD.gn	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	components/plugins.gypi	View		3 chunks	+3 lines, -0 lines	0 comments	Download
A	components/plugins/renderer/BUILD.gn	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A +	components/search_provider_logos/BUILD.gn	View		1 chunk	+10 lines, -8 lines	0 comments	Download
M	components/sessions.gypi	View		4 chunks	+4 lines, -0 lines	0 comments	Download
A	components/sessions/BUILD.gn	View		1 chunk	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM w/question. https://codereview.chromium.org/397953005/diff/60001/components/password_manager/core/browser/BUILD.gn File components/password_manager/core/browser/BUILD.gn (right): https://codereview.chromium.org/397953005/diff/60001/components/password_manager/core/browser/BUILD.gn#newcode11 components/password_manager/core/browser/BUILD.gn:11: if (!is_android || !is_android_webview_build) { One would ...

6 years, 5 months ago (2014-07-16 19:21:59 UTC) #2

brettw

https://codereview.chromium.org/397953005/diff/60001/components/password_manager/core/browser/BUILD.gn File components/password_manager/core/browser/BUILD.gn (right): https://codereview.chromium.org/397953005/diff/60001/components/password_manager/core/browser/BUILD.gn#newcode11 components/password_manager/core/browser/BUILD.gn:11: if (!is_android || !is_android_webview_build) { On 2014/07/16 19:21:59, viettrungluu ...

6 years, 5 months ago (2014-07-16 21:41:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r283521.

Expand Messages | Collapse Messages