Issue 397913003: Kill renderers which try to register Service Workers across domains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397913003: Kill renderers which try to register Service Workers across domains. (Closed)

Created:
6 years, 5 months ago by dominicc (has gone to gerrit)

Modified:
6 years, 5 months ago

Reviewers:
falken

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Kill renderers which try to register Service Workers across domains. There is a same-origin check in ServiceWorkerContainer::registerServiceWorker, so this code should only be reachable if something has gone wrong. BUG=394213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283707

Patch Set 1 #

Patch Set 2 : Rename tests. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -44 lines)			Patch
	M	content/browser/service_worker/service_worker_dispatcher_host.cc	View		3 chunks	+5 lines, -12 lines	0 comments	Download
	M	content/browser/service_worker/service_worker_dispatcher_host_unittest.cc	View	1	3 chunks	+79 lines, -32 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

The CQ bit was checked by dominicc@chromium.org

6 years, 5 months ago (2014-07-17 06:50:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/397913003/20001

6 years, 5 months ago (2014-07-17 06:52:41 UTC) #4

Message was sent while issue was closed.

Change committed as 283707

Expand Messages | Collapse Messages