Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 397903003: Implement sequence<MediaStreamTrack> getTracks () This is to conform to the new spec- http://dev.w3… (Closed)

Created:
6 years, 5 months ago by Vinod Keshav
Modified:
6 years, 4 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement sequence<MediaStreamTrack> getTracks () This is to conform to the new spec- http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastream BUG=394212 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html View 6 chunks +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStream.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStream.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Vinod Keshav
Hi tommi, Could you please review this. I have modified the existing layout test to ...
6 years, 5 months ago (2014-07-16 05:06:34 UTC) #1
Vinod Keshav
abarth@ PTAL
6 years, 5 months ago (2014-07-17 02:05:25 UTC) #2
abarth-chromium
Looks fine to me, but let's have one of the WebRTC folks take a look ...
6 years, 5 months ago (2014-07-17 05:25:11 UTC) #3
Vinod Keshav
On 2014/07/17 05:25:11, abarth wrote: > Looks fine to me, but let's have one of ...
6 years, 5 months ago (2014-07-17 05:33:40 UTC) #4
abarth-chromium
Maybe grunell? Looks like he might be out of the office as well. :(
6 years, 5 months ago (2014-07-17 05:44:19 UTC) #5
abarth-chromium
This seems fine.
6 years, 5 months ago (2014-07-17 05:44:56 UTC) #6
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-17 05:44:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/v.keshav@samsung.com/397903003/1
6 years, 5 months ago (2014-07-17 05:45:51 UTC) #8
Vinod Keshav
On 2014/07/17 05:44:56, abarth wrote: > This seems fine. Thank you
6 years, 5 months ago (2014-07-17 06:01:37 UTC) #9
commit-bot: I haz the power
Change committed as 178338
6 years, 5 months ago (2014-07-17 08:43:32 UTC) #10
Henrik Grunell
6 years, 4 months ago (2014-08-11 12:00:56 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698