chrome/browser/extensions/chrome_app_sorting.cc - Issue 397903002: Do not assign launch ordinals to ephemeral apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_app_sorting.cc

Issue 397903002: Do not assign launch ordinals to ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ephemapp_unload_review

Patch Set: Changed implementation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_app_sorting.h ('k') | chrome/browser/extensions/chrome_app_sorting_unittest.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_app_sorting.cc

diff --git a/chrome/browser/extensions/chrome_app_sorting.cc b/chrome/browser/extensions/chrome_app_sorting.cc

index c96ae099db93950475ce0ab547884d7f130c53f0..d7819310997f4ec4eb5884f392b8c4c35e7f9e9a 100644

--- a/chrome/browser/extensions/chrome_app_sorting.cc

+++ b/chrome/browser/extensions/chrome_app_sorting.cc

@@ -435,8 +435,12 @@ syncer::StringOrdinal ChromeAppSorting::PageIntegerAsStringOrdinal(

return ntp_ordinal_map_.rbegin()->first;

}

-void ChromeAppSorting::MarkExtensionAsHidden(const std::string& extension_id) {

- ntp_hidden_extensions_.insert(extension_id);

+void ChromeAppSorting::SetExtensionVisible(const std::string& extension_id,

+ bool visible) {

+ if (visible)

+ ntp_hidden_extensions_.erase(extension_id);

+ else

+ ntp_hidden_extensions_.insert(extension_id);

}

syncer::StringOrdinal ChromeAppSorting::GetMinOrMaxAppLaunchOrdinalsOnPage(