apps/shell/browser/shell_app_sorting.cc - Issue 397903002: Do not assign launch ordinals to ephemeral apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/shell/browser/shell_app_sorting.cc

Issue 397903002: Do not assign launch ordinals to ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ephemapp_unload_review

Patch Set: Changed implementation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « apps/shell/browser/shell_app_sorting.h ('k') | chrome/browser/apps/ephemeral_app_browsertest.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: apps/shell/browser/shell_app_sorting.cc

diff --git a/apps/shell/browser/shell_app_sorting.cc b/apps/shell/browser/shell_app_sorting.cc

index b78d57d8fa8d4063ef3d5dcaee6d178fc08dd476..fa16063aab5b4d96849e2249e6129fe7188ab981 100644

--- a/apps/shell/browser/shell_app_sorting.cc

+++ b/apps/shell/browser/shell_app_sorting.cc

@@ -100,8 +100,8 @@ syncer::StringOrdinal ShellAppSorting::PageIntegerAsStringOrdinal(

return syncer::StringOrdinal(kFirstPage);

}

-void ShellAppSorting::MarkExtensionAsHidden(

- const std::string& extension_id) {

+void ShellAppSorting::SetExtensionVisible(const std::string& extension_id,

+ bool visible) {

}

} // namespace apps