extensions/browser/app_sorting.h - Issue 397903002: Do not assign launch ordinals to ephemeral apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_sorting.h

Issue 397903002: Do not assign launch ordinals to ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ephemapp_unload_review

Patch Set: Minor clean up Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_sorting.h

diff --git a/extensions/browser/app_sorting.h b/extensions/browser/app_sorting.h

index 75edf637477917e565459ecd6d4ac2248f51e17a..39d50dcd16c45c4393ac9dfc054a9b498d88a7d9 100644

--- a/extensions/browser/app_sorting.h

+++ b/extensions/browser/app_sorting.h

@@ -109,8 +109,10 @@ class AppSorting {

virtual syncer::StringOrdinal PageIntegerAsStringOrdinal(

size_t page_index) = 0;

- // Hidden extensions don't appear in the new tab page.

- virtual void MarkExtensionAsHidden(const std::string& extension_id) = 0;

+ // Hides an extension from the new tab page, or makes a previously hidden

+ // extension visible.

+ virtual void SetExtensionVisible(const std::string& extension_id,

+ bool visible) = 0;

private:

DISALLOW_COPY_AND_ASSIGN(AppSorting);

« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »