Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4718)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 397903002: Do not assign launch ordinals to ephemeral apps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ephemapp_unload_review
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 6a0b4b6e4410f62ba0964d252c1a163df7999f7b..187473224ffc97733c89ee04b00271d698b961ea 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1845,6 +1845,9 @@ void ExtensionService::PromoteEphemeralApp(
DCHECK(GetInstalledExtension(extension->id()) &&
extension_prefs_->IsEphemeralApp(extension->id()));
+ // Remove the ephemeral flags from the preferences.
+ extension_prefs_->OnEphemeralAppPromoted(extension->id());
+
if (!is_from_sync) {
if (extension->RequiresSortOrdinal()) {
// Reset the sort ordinals of the app to ensure it is added to the default
@@ -1855,9 +1858,6 @@ void ExtensionService::PromoteEphemeralApp(
}
}
- // Remove the ephemeral flags from the preferences.
- extension_prefs_->OnEphemeralAppPromoted(extension->id());
-
// Fire install-related events to allow observers to handle the promotion
// of the ephemeral app.
extensions::InstalledExtensionInfo details(

Powered by Google App Engine
This is Rietveld 408576698