Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 397893002: Revert of [Blink] XMLTreeViewer should load resources from blink_resources.grd instead... (Closed)

Created:
6 years, 5 months ago by falken
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py… (https://codereview.chromium.org/394003002/) Reason for revert: I think this probably caused a build failure on Android GN: http://build.chromium.org/p/chromium.webkit/builders/Android%20GN/builds/3213 http://build.chromium.org/p/chromium.webkit/builders/Android%20GN/builds/3212 Excerpt from log: FAILED: python ../../build/android/gyp/process_resources.py --depfile gen/ui/android/ui_java_res__process_resources.d --android-sdk ../../third_party/android_tools/sdk/platforms/android-19 --android-sdk-tools ../../third_party/android_tools/sdk/build-tools/19.0.0 --non-constant-id --android-manifest ../../build/android/AndroidManifest.xml --resource-dirs=\[\"../../ui/android/java/res\"\] --srcjar-out gen/ui/android/ui_java_res.srcjar --resource-zip-out gen/ui/android/ui_java_res.resources.zip --dependencies-res-zips=@\(gen/ui/android/ui_java_res.build_config:resources:dependency_zips\) --custom-package org.chromium.ui Traceback (most recent call last): File "../../build/android/gyp/process_resources.py", line 260, in <module> main() File "../../build/android/gyp/process_resources.py", line 215, in main build_utils.CheckOutput(package_command, print_stderr=False) File "/mnt/data/b/build/slave/Android_GN/build/src/build/android/gyp/util/build_utils.py", line 154, in CheckOutput raise CalledProcessError(cwd, args, stdout + stderr) util.build_utils.CalledProcessError: Command failed: ( cd /mnt/data/b/build/slave/Android_GN/build/src/out/Release; ../../third_party/android_tools/sdk/build-tools/19.0.0/aapt package -m -M ../../build/android/AndroidManifest.xml --auto-add-overlay -I ../../third_party/android_tools/sdk/platforms/android-19/android.jar --output-text-symbols /tmp/tmpX2vkJ3/gen -J /tmp/tmpX2vkJ3/gen -S ../../ui/android/java/res -S /tmp/tmpX2vkJ3/deps/ui_strings_grd.resources.zip --non-constant-id --custom-package org.chromium.ui ) ../../third_party/android_tools/sdk/build-tools/19.0.0/aapt: error while loading shared libraries: libz.so.1: cannot open shared object file: No such file or directory ninja: build stopped: subcommand failed. Original issue's description: > [Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py (Part-1) > > Blink should make use of blink_resources.grd for the inline resources for displaying XML tree view. > This removes the dependency upon using xxd.py which embeds the resources as strings. > > BUG=312586 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178214 TBR=abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M public/blink_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
Created Revert of [Blink] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py…
6 years, 5 months ago (2014-07-16 02:32:38 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 5 months ago (2014-07-16 02:32:55 UTC) #2
falken
A revert of this CL has been created in https://codereview.chromium.org/393213002/ by falken@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-16 03:59:54 UTC) #3
jamesr
On 2014/07/16 03:59:54, falken wrote: > A revert of this CL has been created in ...
6 years, 5 months ago (2014-07-16 05:58:42 UTC) #4
falken
6 years, 5 months ago (2014-07-16 06:55:00 UTC) #5
Message was sent while issue was closed.
On 2014/07/16 05:58:42, jamesr wrote:
> On 2014/07/16 03:59:54, falken wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/393213002/ by mailto:falken@chromium.org.
> > 
> > The reason for reverting is: The revert didn't fix the problem. It turns out
a
> > clobber healed the bot..
> 
> Could you please file a bug with the failing log and a link to the patch?  We
> should be pretty robust to incremental build issues with generated content in
> GN, it'd be very interesting to see what the missing dep is.

Sure, done: https://code.google.com/p/chromium/issues/detail?id=394239

Powered by Google App Engine
This is Rietveld 408576698