Issue 397883005: Removing the webmediaplayer check in ImageBitmapFactories::createImageBitmap which is not required …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397883005: Removing the webmediaplayer check in ImageBitmapFactories::createImageBitmap which is not required … (Closed)

Created:
6 years, 5 months ago by Srirama

Modified:
6 years, 5 months ago

Reviewers:
arbesfeld, acolwell GONE FROM CHROMIUM, Sikugu_, Justin Novosad, philipj_slow

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Removing webmediaplayer check in createImageBitmap() Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178315

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/modules/imagebitmap/ImageBitmapFactories.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

Srirama

As the BUG=382721 is fixed now, the webmediaplayer check is not required in ImageBitmapFactories::createImageBitmap. PTAL

6 years, 5 months ago (2014-07-16 15:46:54 UTC) #1

philipj_slow

LGTM, but per Source/modules/imagebitmap/OWNERS you'll have to get arbesfeld@chromium.org or junov@chromium.org to review it in ...

6 years, 5 months ago (2014-07-16 16:17:57 UTC) #2

Justin Novosad

On 2014/07/16 16:19:02, philipj wrote: > +arbesfeld +junov Assuming 382721 is fixed, lgtm

6 years, 5 months ago (2014-07-16 19:47:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/397883005/1

6 years, 5 months ago (2014-07-17 04:15:03 UTC) #6

Message was sent while issue was closed.

Change committed as 178315