Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 397873004: Make GrLayerCache use multiple plots in its atlas (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make GrLayerCache use multiple plots in its atlas Until we have a recycling Rectanizer the atlas purging must occur at the GrPlot level. This CL breaks the atlas into four plots to give some room for purging (without trashing the entire atlas). This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/) Committed: https://skia.googlesource.com/skia/+/261b8a98dc7378989ba8fa9c06b728e89162862b

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Fixed comment #

Patch Set 4 : Try to pacify clang #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -25 lines) Patch
M src/gpu/GrLayerCache.h View 1 2 4 chunks +36 lines, -11 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 7 chunks +73 lines, -14 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-16 17:40:14 UTC) #1
jvanverth1
https://codereview.chromium.org/397873004/diff/60001/src/gpu/GrLayerCache.cpp File src/gpu/GrLayerCache.cpp (right): https://codereview.chromium.org/397873004/diff/60001/src/gpu/GrLayerCache.cpp#newcode45 src/gpu/GrLayerCache.cpp:45: * PictureKey just wraps a picture's unique ID for ...
6 years, 5 months ago (2014-07-16 21:04:16 UTC) #2
robertphillips
https://codereview.chromium.org/397873004/diff/60001/src/gpu/GrLayerCache.cpp File src/gpu/GrLayerCache.cpp (right): https://codereview.chromium.org/397873004/diff/60001/src/gpu/GrLayerCache.cpp#newcode45 src/gpu/GrLayerCache.cpp:45: * PictureKey just wraps a picture's unique ID for ...
6 years, 5 months ago (2014-07-17 11:57:45 UTC) #3
jvanverth1
lgtm
6 years, 5 months ago (2014-07-17 15:14:45 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-17 15:15:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/397873004/60001
6 years, 5 months ago (2014-07-17 15:16:02 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 15:26:49 UTC) #7
Message was sent while issue was closed.
Change committed as 261b8a98dc7378989ba8fa9c06b728e89162862b

Powered by Google App Engine
This is Rietveld 408576698