content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 397873003: [Android] Fix PEN event values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 397873003: [Android] Fix PEN event values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 004aefd7694173df61b79a8a281c5d1447806afc..904c4c2b7ca67d65ecb618c5a8aa632514f94b7e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -112,11 +112,11 @@ public class ContentViewCore

// Length of the delay (in ms) before fading in handles after the last page movement.

private static final int TEXT_HANDLE_FADE_IN_DELAY = 300;

- // These values are empirically obtained.

- private static final int SPEN_ACTION_DOWN = 11;

- private static final int SPEN_ACTION_UP = 12;

- private static final int SPEN_ACTION_MOVE = 13;

- private static final int SPEN_ACTION_CANCEL = 14;

+ // These values are obtained from Samsung.

+ private static final int SPEN_ACTION_DOWN = 211;

+ private static final int SPEN_ACTION_UP = 212;

+ private static final int SPEN_ACTION_MOVE = 213;

+ private static final int SPEN_ACTION_CANCEL = 214;

private static Boolean sIsSPenSupported;

// If the embedder adds a JavaScript interface object that contains an indirect reference to

« no previous file with comments | « no previous file | no next file » | no next file with comments »