Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4471)

Unified Diff: chrome/browser/profiles/profile.cc

Issue 397853002: Refactor safe-browsing build-config definitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase to satiate trybots Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile.cc
diff --git a/chrome/browser/profiles/profile.cc b/chrome/browser/profiles/profile.cc
index fc5cde6eaf12f7ec39f3c81ad335d405066236d4..7bd6d38532349234ef5b32783ff53fc09122b4f0 100644
--- a/chrome/browser/profiles/profile.cc
+++ b/chrome/browser/profiles/profile.cc
@@ -29,6 +29,7 @@
#include "chromeos/chromeos_switches.h"
#endif
+// TODO(shess): Should possibly be SAFE_BROWSING_SERVICE.
#if defined(OS_ANDROID) && defined(FULL_SAFE_BROWSING)
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#endif
@@ -83,6 +84,8 @@ void Profile::RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
prefs::kSessionExitType,
std::string(),
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+ // TODO(shess): This seems wrongish. Perhaps the API should be in the
+ // service, with the #if OS_ANDROID inside that implementation.
#if defined(OS_ANDROID) && defined(FULL_SAFE_BROWSING)
// During Finch trail, safe browsing should be turned off
// by default, and not sync'ed with desktop.
« no previous file with comments | « chrome/browser/profiles/off_the_record_profile_io_data.cc ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698