Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 397853002: Refactor safe-browsing build-config definitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index 2fbfbc37b498ae6cdb4a33fc4b23858f43d31255..3431e9c7061e72e527b680fb00a50167d99f8484 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -216,6 +216,9 @@ class SafeBrowsingService
// Used to track creation and destruction of profiles on the UI thread.
content::NotificationRegistrar prefs_registrar_;
+ // TODO(shess): Should csd_service_ be guarded by SAFE_BROWSING_CSD? Likewise
+ // for download_service_ and incident_service_?
+
// The ClientSideDetectionService is managed by the SafeBrowsingService,
// since its running state and lifecycle depends on SafeBrowsingService's.
// Accessed on UI thread.

Powered by Google App Engine
This is Rietveld 408576698