Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: build/common.gypi

Issue 397853002: Refactor safe-browsing build-config definitions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase to satiate trybots Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2834 matching lines...) Expand 10 before | Expand all | Expand 10 after
2845 }], 2845 }],
2846 ['enable_hangout_services_extension==1', { 2846 ['enable_hangout_services_extension==1', {
2847 'defines': ['ENABLE_HANGOUT_SERVICES_EXTENSION=1'], 2847 'defines': ['ENABLE_HANGOUT_SERVICES_EXTENSION=1'],
2848 }], 2848 }],
2849 ['enable_ipc_fuzzer==1', { 2849 ['enable_ipc_fuzzer==1', {
2850 'defines': ['ENABLE_IPC_FUZZER=1'], 2850 'defines': ['ENABLE_IPC_FUZZER=1'],
2851 }], 2851 }],
2852 ['video_hole==1', { 2852 ['video_hole==1', {
2853 'defines': ['VIDEO_HOLE=1'], 2853 'defines': ['VIDEO_HOLE=1'],
2854 }], 2854 }],
2855
2856 # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service.
2857 # SAFE_BROWSING_DATABASE - service manages a local database.
2858 # SAFE_BROWSING_CSD - enable client-side phishing detection.
2859 ['safe_browsing==1', {
2860 'defines': [
2861 'FULL_SAFE_BROWSING',
2862 'SAFE_BROWSING_CSD',
2863 'SAFE_BROWSING_DATABASE',
2864 'SAFE_BROWSING_SERVICE',
2865 ],
2866 }],
2867 # TODO(shess): I believe this case is no longer in use.
2868 ['safe_browsing==2', {
2869 'defines': [
2870 'MOBILE_SAFE_BROWSING',
2871 'SAFE_BROWSING_SERVICE',
2872 ],
2873 }],
2855 ], # conditions for 'target_defaults' 2874 ], # conditions for 'target_defaults'
2856 'target_conditions': [ 2875 'target_conditions': [
2857 ['<(use_openssl)==1', { 2876 ['<(use_openssl)==1', {
2858 'defines': ['USE_OPENSSL=1'], 2877 'defines': ['USE_OPENSSL=1'],
2859 }], 2878 }],
2860 ['<(use_openssl_certs)==1', { 2879 ['<(use_openssl_certs)==1', {
2861 'defines': ['USE_OPENSSL_CERTS=1'], 2880 'defines': ['USE_OPENSSL_CERTS=1'],
2862 }], 2881 }],
2863 ['>(nacl_untrusted_build)==1', { 2882 ['>(nacl_untrusted_build)==1', {
2864 'defines': [ 2883 'defines': [
(...skipping 2807 matching lines...) Expand 10 before | Expand all | Expand 10 after
5672 # settings in target dicts. SYMROOT is a special case, because many other 5691 # settings in target dicts. SYMROOT is a special case, because many other
5673 # Xcode variables depend on it, including variables such as 5692 # Xcode variables depend on it, including variables such as
5674 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5693 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5675 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5694 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5676 # files to appear (when present) in the UI as actual files and not red 5695 # files to appear (when present) in the UI as actual files and not red
5677 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5696 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5678 # and therefore SYMROOT, needs to be set at the project level. 5697 # and therefore SYMROOT, needs to be set at the project level.
5679 'SYMROOT': '<(DEPTH)/xcodebuild', 5698 'SYMROOT': '<(DEPTH)/xcodebuild',
5680 }, 5699 },
5681 } 5700 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698