Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 397843009: Revert of DevTools: Support async call stacks for FileSystem API (part 1). (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
kinuko, aandrey, nhiroki, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, tzik, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kinuko+fileapi
Project:
blink
Visibility:
Public.

Description

Revert of DevTools: Support async call stacks for FileSystem API (part 1). (https://codereview.chromium.org/383123009/) Reason for revert: This seems to add a lot of complexity into async code + violates the modularity: core/inspector should not be aware of the filesystems. Original issue's description: > DevTools: Support async call stacks for FileSystem API (part 1). > > This patch does not yet tracks async stacks for FileWriter and FileReader. > > BUG=272416, 390863 > R=kinuko@chromium.org, nhiroki@chromium.org, yurys > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178149 TBR=kinuko@chromium.org,nhiroki@chromium.org,yurys@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=272416, 390863 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -374 lines) Patch
D LayoutTests/http/tests/inspector/filesystem/async-callstack-filesystem.html View 1 chunk +0 lines, -111 lines 0 comments Download
D LayoutTests/http/tests/inspector/filesystem/async-callstack-filesystem-expected.txt View 1 chunk +0 lines, -60 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 8 chunks +2 lines, -60 lines 0 comments Download
M Source/core/inspector/CodeGeneratorInstrumentation.py View 4 chunks +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 3 chunks +1 line, -16 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 4 chunks +4 lines, -20 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.cpp View 7 chunks +9 lines, -55 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of DevTools: Support async call stacks for FileSystem API (part 1).
6 years, 5 months ago (2014-07-16 12:09:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/397843009/1
6 years, 5 months ago (2014-07-16 12:10:58 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 12:11:35 UTC) #3
Message was sent while issue was closed.
Change committed as 178269

Powered by Google App Engine
This is Rietveld 408576698