Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart

Issue 397843005: Lazily load the entrypoint. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart
diff --git a/sdk/lib/_internal/pub/test/list_package_dirs/no_lockfile_test.dart b/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart
similarity index 57%
copy from sdk/lib/_internal/pub/test/list_package_dirs/no_lockfile_test.dart
copy to sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart
index 3bbc72a47f4967178839757f1c9b06cf7ee24b7b..da2feb35130202af39eb43d6f128f50b896ee4c0 100644
--- a/sdk/lib/_internal/pub/test/list_package_dirs/no_lockfile_test.dart
+++ b/sdk/lib/_internal/pub/test/list_package_dirs/missing_pubspec_test.dart
@@ -2,23 +2,25 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE d.file.
-import '../../lib/src/exit_codes.dart' as exit_codes;
+import 'package:path/path.dart' as path;
+import '../../lib/src/exit_codes.dart' as exit_codes;
+import '../../lib/src/io.dart';
import '../descriptor.dart' as d;
import '../test_pub.dart';
main() {
initConfig();
- integration('with no lockfile, exits with error', () {
- d.dir(appPath, [
- d.appPubspec()
- ]).create();
+ // This is a regression test for #20065.
+ integration("reports a missing pubspec error using JSON", () {
+ d.dir(appPath).create();
schedulePub(args: ["list-package-dirs", "--format=json"],
outputJson: {
"error":
- 'Package "myapp" has no lockfile. Please run "pub get" first.'
+ 'Could not find a file named "pubspec.yaml" in "'
+ '${canonicalize(path.join(sandboxDir, appPath))}".'
},
- exitCode: exit_codes.DATA);
+ exitCode: 1);
});
}

Powered by Google App Engine
This is Rietveld 408576698