Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 397833002: Lower the rest of the vector arithmetic operations. (Closed)

Created:
6 years, 5 months ago by wala
Modified:
6 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Lower the rest of the vector arithmetic operations. The instructions emitted by the lowering operations require memory operands to be aligned to 16 bytes. Since there is no support for aligning memory operands in Subzero, do the arithmetic in registers for now. Add vector arithmetic to the arith crosstest. Pass the -mstackrealign parameter to the crosstest clang so that llc code called back from Subzero code (helper calls) doesn't assume that the stack is aligned at the entry to the call. BUG=none R=jvoung@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7fa22d8

Patch Set 1 #

Patch Set 2 : Format crosstest.py #

Total comments: 19

Patch Set 3 : First round of changes #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+938 lines, -82 lines) Patch
M crosstest/crosstest.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M crosstest/test_arith.h View 2 chunks +21 lines, -3 lines 0 comments Download
M crosstest/test_arith.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M crosstest/test_arith.def View 1 chunk +23 lines, -0 lines 0 comments Download
M crosstest/test_arith_frem.ll View 1 chunk +5 lines, -0 lines 0 comments Download
M crosstest/test_arith_main.cpp View 1 2 12 chunks +223 lines, -42 lines 0 comments Download
M src/IceInstX8632.h View 1 2 3 6 chunks +53 lines, -1 line 0 comments Download
M src/IceInstX8632.cpp View 1 2 3 7 chunks +82 lines, -6 lines 0 comments Download
M src/IceInstX8632.def View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8632.h View 1 2 3 4 chunks +20 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 2 chunks +183 lines, -21 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arith.ll View 1 chunk +314 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
wala
6 years, 5 months ago (2014-07-15 22:16:41 UTC) #1
Jim Stichnoth
lgtm with nits https://codereview.chromium.org/397833002/diff/20001/crosstest/crosstest.py File crosstest/crosstest.py (right): https://codereview.chromium.org/397833002/diff/20001/crosstest/crosstest.py#newcode133 crosstest/crosstest.py:133: shellcmd([os.path.join(llvm_bin_path, linker), '-g', '-m32', '-mstackrealign', 80-col ...
6 years, 5 months ago (2014-07-16 19:17:11 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/397833002/diff/20001/crosstest/crosstest.py File crosstest/crosstest.py (right): https://codereview.chromium.org/397833002/diff/20001/crosstest/crosstest.py#newcode133 crosstest/crosstest.py:133: shellcmd([os.path.join(llvm_bin_path, linker), '-g', '-m32', '-mstackrealign', Add a TODO to ...
6 years, 5 months ago (2014-07-16 19:23:26 UTC) #3
wala
https://codereview.chromium.org/397833002/diff/20001/crosstest/crosstest.py File crosstest/crosstest.py (right): https://codereview.chromium.org/397833002/diff/20001/crosstest/crosstest.py#newcode133 crosstest/crosstest.py:133: shellcmd([os.path.join(llvm_bin_path, linker), '-g', '-m32', '-mstackrealign', On 2014/07/16 19:17:10, stichnot ...
6 years, 5 months ago (2014-07-17 01:34:54 UTC) #4
Jim Stichnoth
https://codereview.chromium.org/397833002/diff/20001/crosstest/test_arith_main.cpp File crosstest/test_arith_main.cpp (right): https://codereview.chromium.org/397833002/diff/20001/crosstest/test_arith_main.cpp#newcode127 crosstest/test_arith_main.cpp:127: // TODO: Replace with a portable PRNG from C++11. ...
6 years, 5 months ago (2014-07-17 13:03:13 UTC) #5
jvoung (off chromium)
lgtm https://codereview.chromium.org/397833002/diff/20001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/397833002/diff/20001/src/IceTargetLoweringX8632.cpp#newcode1199 src/IceTargetLoweringX8632.cpp:1199: // pshufd T2, Src0, [1,0,3,0] On 2014/07/17 01:34:53, ...
6 years, 5 months ago (2014-07-17 15:00:39 UTC) #6
wala
6 years, 5 months ago (2014-07-17 19:41:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r7fa22d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698