Source/core/rendering/RenderBlockFlow.h - Issue 39783004: Fake Bidi run does not need to be always created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlockFlow.h

Issue 39783004: Fake Bidi run does not need to be always created (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Trying again Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBlockFlow.h

diff --git a/Source/core/rendering/RenderBlockFlow.h b/Source/core/rendering/RenderBlockFlow.h

index 8592c32c35c3e0f8e46707b4124270e7d14d84aa..19dc40d7b3dcae6cafa126480c84a6ed2937002a 100644

--- a/Source/core/rendering/RenderBlockFlow.h

+++ b/Source/core/rendering/RenderBlockFlow.h

@@ -342,9 +342,6 @@ protected:

// RenderBlockLineLayout. They should be moved to the proper header once the

// line layout code is separated from RenderBlock and RenderBlockFlow.

// START METHODS DEFINED IN RenderBlockLineLayout

-public:

- static void appendRunsForObject(BidiRunList<BidiRun>&, int start, int end, RenderObject*, InlineBidiResolver&);

private:

InlineFlowBox* createLineBoxes(RenderObject*, const LineInfo&, InlineBox* childBox, bool startsNewSegment);

RootInlineBox* constructLine(BidiRunList<BidiRun>&, const LineInfo&);