Source/devtools/front_end/timeline/TimelinePanel.js - Issue 397823003: DevTools: Support multiple target in TimelineModelImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 397823003: DevTools: Support multiple target in TimelineModelImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/timeline/TimelineModelImpl.js ('K') | « Source/devtools/front_end/timeline/TimelineModelImpl.js ('k') | Source/devtools/front_end/timeline/TimelineView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js

index 7ccc512831c0f8a2a040db1e4be6581914a8e391..d25cff931ef3d66c9efb5254d6441a6eabc04be0 100644

--- a/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -84,7 +84,7 @@ WebInspector.TimelinePanel = function()

this._model = this._tracingTimelineModel;

} else {

this._uiUtils = new WebInspector.TimelineUIUtilsImpl();

- this._model = new WebInspector.TimelineModelImpl(WebInspector.timelineManager);

+ this._model = new WebInspector.TimelineModelImpl();

}

this._model.addEventListener(WebInspector.TimelineModel.Events.RecordingStarted, this._onRecordingStarted, this);

@@ -1039,7 +1039,7 @@ WebInspector.TimelinePanel.prototype = {

break;

}

var title = this._uiUtils.titleForRecord(record);

- this._uiUtils.generateDetailsContent(record, this._model, this._detailsLinkifier, this.showInDetails.bind(this, title), this._model.loadedFromFile());

+ this._uiUtils.generateDetailsContent(record, this._model, this._detailsLinkifier, this.showInDetails.bind(this, title));

break;

case WebInspector.TimelineSelection.Type.TraceEvent:

var event = /** @type {!WebInspector.TracingModel.Event} */ (this._selection.object());