Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397823003: DevTools: Support multiple target in TimelineModelImpl (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Support multiple target in TimelineModelImpl BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178567

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address yurys's comments #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -44 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-receive-response-event.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 10 chunks +50 lines, -25 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sergeyv
6 years, 5 months ago (2014-07-19 11:15:31 UTC) #1
yurys
https://codereview.chromium.org/397823003/diff/1/Source/devtools/front_end/timeline/TimelineModelImpl.js File Source/devtools/front_end/timeline/TimelineModelImpl.js (right): https://codereview.chromium.org/397823003/diff/1/Source/devtools/front_end/timeline/TimelineModelImpl.js#newcode54 Source/devtools/front_end/timeline/TimelineModelImpl.js:54: if (!this._currentTarget) How can this happen? Shouldn't we fail ...
6 years, 5 months ago (2014-07-21 09:55:20 UTC) #2
sergeyv
https://codereview.chromium.org/397823003/diff/1/Source/devtools/front_end/timeline/TimelineModelImpl.js File Source/devtools/front_end/timeline/TimelineModelImpl.js (right): https://codereview.chromium.org/397823003/diff/1/Source/devtools/front_end/timeline/TimelineModelImpl.js#newcode114 Source/devtools/front_end/timeline/TimelineModelImpl.js:114: if (!event.data || this._collectionEnabled) On 2014/07/21 09:55:20, yurys wrote: ...
6 years, 5 months ago (2014-07-21 12:39:11 UTC) #3
yurys
LGTM, but please make sure that caseq is fine w/ this change.
6 years, 5 months ago (2014-07-21 12:47:11 UTC) #4
caseq
lgtm
6 years, 5 months ago (2014-07-21 13:53:40 UTC) #5
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-21 13:57:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397823003/20001
6 years, 5 months ago (2014-07-21 13:57:32 UTC) #7
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-21 15:06:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/397823003/40001
6 years, 5 months ago (2014-07-21 15:06:30 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 16:08:58 UTC) #10
Message was sent while issue was closed. 
Change committed as 178567

Powered by Google App Engine
This is Rietveld 408576698