Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/devtools/protocol.json

Issue 397813006: DevTools: move events array from Timeline.stop response to Timeline.stopped (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 { 1 {
2 "version": { "major": "1", "minor": "1" }, 2 "version": { "major": "1", "minor": "1" },
3 "domains": [{ 3 "domains": [{
4 "domain": "Inspector", 4 "domain": "Inspector",
5 "hidden": true, 5 "hidden": true,
6 "types": [], 6 "types": [],
7 "commands": [ 7 "commands": [
8 { 8 {
9 "name": "enable", 9 "name": "enable",
10 "description": "Enables inspector domain notifications." 10 "description": "Enables inspector domain notifications."
(...skipping 2879 matching lines...) Expand 10 before | Expand all | Expand 10 after
2890 { "name": "maxCallStackDepth", "optional": true, "type": "in teger", "description": "Samples JavaScript stack traces up to <code>maxCallStack Depth</code>, defaults to 5." }, 2890 { "name": "maxCallStackDepth", "optional": true, "type": "in teger", "description": "Samples JavaScript stack traces up to <code>maxCallStack Depth</code>, defaults to 5." },
2891 { "name": "bufferEvents", "optional": true, "type": "boolean ", "hidden": true, "description": "Whether instrumentation events should be buff ered and returned upon <code>stop</code> call." }, 2891 { "name": "bufferEvents", "optional": true, "type": "boolean ", "hidden": true, "description": "Whether instrumentation events should be buff ered and returned upon <code>stop</code> call." },
2892 { "name": "liveEvents", "optional": true, "type": "string", "hidden": true, "description": "Coma separated event types to issue although buf ferEvents is set."}, 2892 { "name": "liveEvents", "optional": true, "type": "string", "hidden": true, "description": "Coma separated event types to issue although buf ferEvents is set."},
2893 { "name": "includeCounters", "optional": true, "type": "bool ean", "hidden": true, "description": "Whether counters data should be included i nto timeline events." }, 2893 { "name": "includeCounters", "optional": true, "type": "bool ean", "hidden": true, "description": "Whether counters data should be included i nto timeline events." },
2894 { "name": "includeGPUEvents", "optional": true, "type": "boo lean", "hidden": true, "description": "Whether events from GPU process should be collected." } 2894 { "name": "includeGPUEvents", "optional": true, "type": "boo lean", "hidden": true, "description": "Whether events from GPU process should be collected." }
2895 ], 2895 ],
2896 "description": "Starts capturing instrumentation events." 2896 "description": "Starts capturing instrumentation events."
2897 }, 2897 },
2898 { 2898 {
2899 "name": "stop", 2899 "name": "stop",
2900 "description": "Stops capturing instrumentation events.", 2900 "description": "Stops capturing instrumentation events."
2901 "returns": [
2902 { "name": "events", "type": "array", "items": { "$ref": "Tim elineEvent" }, "optional": true, "hidden": true, "description": "Timeline event record data." }
2903 ]
2904 } 2901 }
2905 ], 2902 ],
2906 "events": [ 2903 "events": [
2907 { 2904 {
2908 "name": "eventRecorded", 2905 "name": "eventRecorded",
2909 "parameters": [ 2906 "parameters": [
2910 { "name": "record", "$ref": "TimelineEvent", "description": "Timeline event record data." } 2907 { "name": "record", "$ref": "TimelineEvent", "description": "Timeline event record data." }
2911 ], 2908 ],
2912 "description": "Fired for every instrumentation event while time line is started." 2909 "description": "Fired for every instrumentation event while time line is started."
2913 }, 2910 },
2914 { 2911 {
2915 "name": "progress", 2912 "name": "progress",
2916 "parameters": [ 2913 "parameters": [
2917 { "name": "count", "type": "number" } 2914 { "name": "count", "type": "number" }
2918 ], 2915 ],
2919 "hidden": true 2916 "hidden": true
2920 }, 2917 },
2921 { 2918 {
2922 "name": "started", 2919 "name": "started",
2923 "parameters": [ 2920 "parameters": [
2924 { "name": "consoleTimeline", "type": "boolean", "optional": true, "description": "If specified, identifies that timeline was started using c onsole.timeline() call." } 2921 { "name": "consoleTimeline", "type": "boolean", "optional": true, "description": "If specified, identifies that timeline was started using c onsole.timeline() call." }
2925 ], 2922 ],
2926 "description": "Fired when timeline is started.", 2923 "description": "Fired when timeline is started.",
2927 "hidden": true 2924 "hidden": true
2928 }, 2925 },
2929 { 2926 {
2930 "name": "stopped", 2927 "name": "stopped",
2931 "parameters": [ 2928 "parameters": [
2932 { "name": "consoleTimeline", "type": "boolean", "optional": true, "description": "If specified, identifies that timeline was started using c onsole.timeline() call." } 2929 { "name": "consoleTimeline", "type": "boolean", "optional": true, "description": "If specified, identifies that timeline was started using c onsole.timeline() call." },
2930 { "name": "events", "type": "array", "items": { "$ref": "Tim elineEvent" }, "optional": true, "hidden": true, "description": "Timeline event record data." }
alph 2014/07/18 10:47:44 We could consider making eventRecorded to allow pa
loislo 2014/07/18 11:42:24 I think it doesn't matter in general because we ar
2933 ], 2931 ],
2934 "description": "Fired when timeline is stopped.", 2932 "description": "Fired when timeline is stopped.",
2935 "hidden": true 2933 "hidden": true
2936 } 2934 }
2937 ] 2935 ]
2938 }, 2936 },
2939 { 2937 {
2940 "domain": "Debugger", 2938 "domain": "Debugger",
2941 "description": "Debugger domain exposes JavaScript debugging capabilitie s. It allows setting and removing breakpoints, stepping through execution, explo ring stack traces, etc.", 2939 "description": "Debugger domain exposes JavaScript debugging capabilitie s. It allows setting and removing breakpoints, stepping through execution, explo ring stack traces, etc.",
2942 "types": [ 2940 "types": [
(...skipping 1312 matching lines...) Expand 10 before | Expand all | Expand 10 after
4255 { 4253 {
4256 "name": "dataAvailable", 4254 "name": "dataAvailable",
4257 "parameters": [ 4255 "parameters": [
4258 {"name": "value", "type": "array", "items": { "$ref": "Power Event" }, "description": "List of power events." } 4256 {"name": "value", "type": "array", "items": { "$ref": "Power Event" }, "description": "List of power events." }
4259 ], 4257 ],
4260 "handlers": ["browser", "frontend"] 4258 "handlers": ["browser", "frontend"]
4261 } 4259 }
4262 ] 4260 ]
4263 }] 4261 }]
4264 } 4262 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698