DevTools: move events array from Timeline.stop response to Timeline.stopped

Source/devtools/front_end/sdk/TimelineManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 83 matching lines @@
 
         var masterError = null;
         var masterProfile = null;
         var callbackBarrier = new CallbackBarrier();
 
         if (this._jsProfilerStarted) {
             ProfilerAgent.stop(callbackBarrier.createCallback(profilerCallback));
             this._jsProfilerStarted = false;
         }
         if (!this._enablementCount)
-            TimelineAgent.stop(callbackBarrier.createCallback(this._processBufferedEvents.bind(this, timelineCallback)));
+            TimelineAgent.stop(callbackBarrier.createCallback(timelineCallback));
 
         callbackBarrier.callWhenDone(allDoneCallback.bind(this));
 
         /**
          * @param {?Protocol.Error} error
          */
         function timelineCallback(error)
         {
             masterError = masterError || error;
         }
@@ skipping 12 matching lines @@
          * @this {WebInspector.TimelineManager}
          */
         function allDoneCallback()
         {
             this.target().profilingLock.release();
             callback(masterError, masterProfile);
         }
     },
 
     /**
-     * @param {function(?Protocol.Error)|undefined} callback
-     * @param {?Protocol.Error} error
      * @param {!Array.<!TimelineAgent.TimelineEvent>=} events
      */
-    _processBufferedEvents: function(callback, error, events)
+    _processBufferedEvents: function(events)
     {
         if (events) {
             for (var i = 0; i < events.length; ++i)
                 this._dispatcher.eventRecorded(events[i]);
         }
-        if (callback)
-            callback(error);
     },
 
     _configureCpuProfilerSamplingInterval: function()
     {
         var intervalUs = WebInspector.settings.highResolutionCpuProfiling.get() ? 100 : 1000;
         ProfilerAgent.setSamplingInterval(intervalUs, didChangeInterval.bind(this));
 
         /**
          * @this {WebInspector.TimelineManager}
          */
@@ skipping 42 matching lines @@
         if (consoleTimeline) {
             // Wake up timeline panel module.
             WebInspector.moduleManager.loadModule("timeline");
         }
         this._started = true;
         this._manager.dispatchEventToListeners(WebInspector.TimelineManager.EventTypes.TimelineStarted, consoleTimeline);
     },
 
     /**
      * @param {boolean=} consoleTimeline
+     * @param {!Array.<!TimelineAgent.TimelineEvent>=} events
      */
-    stopped: function(consoleTimeline)
+    stopped: function(consoleTimeline, events)
     {
         this._started = false;
         this._manager.dispatchEventToListeners(WebInspector.TimelineManager.EventTypes.TimelineStopped, consoleTimeline);
+        this._manager._processBufferedEvents(events);

[alph, 2014/07/18 10:47:43]

Perhaps it's better to processBufferedEvents before dispatching TimelineStopped
event. wdyt?

[loislo, 2014/07/18 11:42:24]

When we start the timeline we may specify a filter for the event types which
will be sent to the front_end unbuffered. So when stopped event arrives we need
to remove such the events (reset the model) and process the buffered events.

     },
 
     /**
      * @param {number} count
      */
     progress: function(count)
     {
         this._manager.dispatchEventToListeners(WebInspector.TimelineManager.EventTypes.TimelineProgress, count);
     }
 }
 
 /**
  * @type {!WebInspector.TimelineManager}
  */
 WebInspector.timelineManager;