Issue 397813004: Video Player: Add a message which is shown on casting

Issue 397813004: Video Player: Add a message which is shown on casting (Closed)

Created:
6 years, 5 months ago by yoshiki

Modified:
6 years, 5 months ago

Reviewers:
fukino

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Video Player: Add a message which is shown on casting This patch shows a message like "Playing on xxxx", andd adds the dummy video element which will be used to control the casting video. BUG=305511 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284180

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed the comments #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -9 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/file_manager/video_player/css/cast_menu.css	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/file_manager/video_player/css/header.css	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/file_manager/video_player/css/video_player.css	View	1	2 chunks	+44 lines, -2 lines	0 comments	Download
A	ui/file_manager/video_player/images/100/cast_big.png	View		Binary file		0 comments	Download
A	ui/file_manager/video_player/images/200/cast_big.png	View		Binary file		0 comments	Download
A	ui/file_manager/video_player/js/cast/cast_video_element.js	View	1	1 chunk	+114 lines, -0 lines	0 comments	Download
M	ui/file_manager/video_player/js/video_player.js	View		5 chunks	+47 lines, -6 lines	0 comments	Download
M	ui/file_manager/video_player/js/video_player_scripts.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/file_manager/video_player/video_player.html	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

fukino

lgtm with nits: https://codereview.chromium.org/397813004/diff/110001/ui/file_manager/video_player/css/video_player.css File ui/file_manager/video_player/css/video_player.css (right): https://codereview.chromium.org/397813004/diff/110001/ui/file_manager/video_player/css/video_player.css#newcode46 ui/file_manager/video_player/css/video_player.css:46: position: absolute; nit: should be sorted ...

6 years, 5 months ago (2014-07-18 10:18:44 UTC) #2

yoshiki

https://codereview.chromium.org/397813004/diff/110001/ui/file_manager/video_player/css/video_player.css File ui/file_manager/video_player/css/video_player.css (right): https://codereview.chromium.org/397813004/diff/110001/ui/file_manager/video_player/css/video_player.css#newcode46 ui/file_manager/video_player/css/video_player.css:46: position: absolute; On 2014/07/18 10:18:43, fukino wrote: > nit: ...

6 years, 5 months ago (2014-07-18 15:56:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/397813004/150001

6 years, 5 months ago (2014-07-18 15:57:30 UTC) #5

Message was sent while issue was closed.

Change committed as 284180

Expand Messages | Collapse Messages