Support XI2 in PlatformKeycodeFromNative()

Support XI2 in PlatformKeycodeFromNative()

R=sadrul@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283931

[sadrul, 2014-07-17 16:14:34]

lgtm. Thanks for the quick fix!

https://codereview.chromium.org/397803007/diff/1/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/397803007/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:600: break;
NOTREACHED()?

https://codereview.chromium.org/397803007/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:604: break;
NOTREACHED()?

[kpschoedel, 2014-07-17 17:01:45]

https://codereview.chromium.org/397803007/diff/1/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/397803007/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:600: break;
On 2014/07/17 16:14:34, sadrul wrote:
> NOTREACHED()?

Done.

https://codereview.chromium.org/397803007/diff/1/ui/events/x/events_x.cc#newc...
ui/events/x/events_x.cc:604: break;
On 2014/07/17 16:14:34, sadrul wrote:
> NOTREACHED()?

Done.

[kpschoedel, 2014-07-17 17:01:52]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:03:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/397803007/20001

[sadrul, 2014-07-17 17:08:53]

The CQ bit was unchecked by sadrul@chromium.org

[sadrul, 2014-07-17 17:09:14]

Took it out of the CQ

https://codereview.chromium.org/397803007/diff/20001/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/397803007/diff/20001/ui/events/x/events_x.cc#...
ui/events/x/events_x.cc:598: xkey = &xkey_from_xi2.xkey;
You are missing a break; here.

[kpschoedel, 2014-07-17 17:12:31]

https://codereview.chromium.org/397803007/diff/20001/ui/events/x/events_x.cc
File ui/events/x/events_x.cc (right):

https://codereview.chromium.org/397803007/diff/20001/ui/events/x/events_x.cc#...
ui/events/x/events_x.cc:598: xkey = &xkey_from_xi2.xkey;
On 2014/07/17 17:09:14, sadrul wrote:
> You are missing a break; here.

Thanks for catching that.

[sadrul, 2014-07-17 18:28:31]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2014-07-17 18:30:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/397803007/40001

[commit-bot: I haz the power, 2014-07-17 22:00:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-17 22:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 22:22:16]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[sadrul, 2014-07-17 23:21:46]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2014-07-17 23:24:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/397803007/40001

[commit-bot: I haz the power, 2014-07-17 23:55:57]

Change committed as 283931

[Mike West, 2014-07-18 07:15:29]

A revert of this CL has been created in
https://codereview.chromium.org/400893003/ by mkwst@chromium.org.

The reason for reverting is: This is crashing on Linux ChromiumOS Tests under
debug: for example
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Started crashing here:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Stack follows:
EventRewriterTest.TestRewriteCapsLockToControl (run #1):
[ RUN      ] EventRewriterTest.TestRewriteCapsLockToControl
Xlib:  extension "RANDR" missing on display ":9".
[442:442:0717/184628:2623724699:FATAL:events_x.cc(606)] Check failed: false.
#0 0x7fba0e7b959e base::debug::StackTrace::StackTrace()
#1 0x7fba0e84c632 logging::LogMessage::~LogMessage()
#2 0x7fba0bac8feb ui::PlatformKeycodeFromNative()
#3 0x7fba0ba8b357 ui::KeyEvent::KeyEvent()
#4 0x000000cba75a (anonymous namespace)::CheckX11KeyTestCase()
#5 0x000000caa668 (anonymous namespace)::CheckKeyTestCase()
#6 0x000000caec04
chromeos::EventRewriterTest_TestRewriteCapsLockToControl_Test::TestBody()
#7 0x000003e0f1a3
testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#8 0x000003dfc5ae
testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#9 0x000003df3415 testing::Test::Run()
#10 0x000003df3b2b testing::TestInfo::Run()
#11 0x000003df411a testing::TestCase::Run()
#12 0x000003df8728 testing::internal::UnitTestImpl::RunAllTests()
#13 0x000003e07f33
testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#14 0x000003dfe0ce
testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#15 0x000003df83b4 testing::UnitTest::Run()
#16 0x00000685b841 RUN_ALL_TESTS()
#17 0x00000685a8c7 base::TestSuite::Run()
#18 0x00000686d11d content::UnitTestTestSuite::Run()
#19 0x000003f15682 base::internal::RunnableAdapter\u003C>::Run()
#20 0x000003f155ec base::internal::InvokeHelper\u003C>::MakeItSo()
#21 0x000003f1559a base::internal::Invoker\u003C>::Run()
#22 0x000002e896fe base::Callback\u003C>::Run()
#23 0x0000068548d0 base::(anonymous namespace)::LaunchUnitTestsInternal()
#24 0x0000068545c7 base::LaunchUnitTests()
#25 0x000003f15365 main
#26 0x7fba06fb076d __libc_start_main
#27 0x00000076e5c9 \u003Cunknown>.