Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 397803003: Makes it so a node can only the root of one connection at a time (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge again Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index 0624f59b0665ed3d529d773864dded4a4792dad4..e65cc6cf07fde68003dd57648d3873cdfb6b06fc 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -127,12 +127,20 @@ interface ViewManagerService {
SetFocus(uint32 node_id) => (bool success);
// Embeds the app for |url| in the specified node. More specifically this
- // creates a new connection to the specified url, expecting to get an
+ // creates a new connection to the specified url, expecting to get a
// ViewManagerClient and configures it with the root node |node|. Fails
// if |node| was not created by this connection.
+ //
// If a particular client invokes Embed() multiple times with the same url,
// the connection is reused. When this happens the ViewManagerClient is
// notified of the additional roots by way of OnRootAdded().
+ //
+ // A node may only be a root of one connection at a time. Subsequent calls to
+ // Embed() for the same node result in the node being removed from the
+ // current connection. The current connection is told this by way of
+ // OnNodeDeleted().
+ //
+ // This advances the server change id.
Embed(string url, uint32 node_id) => (bool success);
// TODO(sky): move these to a separate interface when FIFO works.
« no previous file with comments | « mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc ('k') | mojo/services/view_manager/root_node_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698