Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/telemetry/telemetry/page/page_set_unittest.py

Issue 397793005: Add Page. TransferToPageSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move TransferToPageSetAPI(..) to page Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_set_unittest.py b/tools/telemetry/telemetry/page/page_set_unittest.py
index 75afb5b7c52bf08ce4587b79f527c255be8d6148..799b010d8396292d131d04cf3fe0be3386cb9130 100644
--- a/tools/telemetry/telemetry/page/page_set_unittest.py
+++ b/tools/telemetry/telemetry/page/page_set_unittest.py
@@ -7,6 +7,7 @@ import tempfile
import unittest
from telemetry.core import util
+from telemetry.page import page
from telemetry.page import page_set
from telemetry.util import cloud_storage
@@ -98,3 +99,24 @@ class TestPageSet(unittest.TestCase):
self.assertEqual(internal_ps.bucket, expected_bucket)
self.assertRaises(ValueError, page_set.PageSet, bucket='garbage_bucket')
+
+ def testFormingPageSetFromSubPageSet(self):
+ page_set_a = page_set.PageSet()
+ pages = [
+ page.Page('http://foo.com', page_set_a),
+ page.Page('http://bar.com', page_set_a),
+ ]
+ for p in pages:
+ page_set_a.AddPage(p)
+
+ # Form page_set_b from sub page_set_a.
+ page_set_b = page_set.PageSet()
+ for p in pages:
+ p.TransferToPageSet(page_set_b)
+ page_set_b.AddPage(page.Page('http://baz.com', page_set_b))
+ self.assertEqual(0, len(page_set_a.pages))
+ self.assertEqual(
+ set(['http://foo.com', 'http://bar.com', 'http://baz.com']),
+ set(p.url for p in page_set_b.pages))
+ for p in page_set_b.pages:
+ self.assertIs(page_set_b, p.page_set)
« no previous file with comments | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698