Replace setsockopt(IP_PKTINFO) and setsockopt(IPV6_RECVPKTINFO) calls by

Replace setsockopt(IP_PKTINFO) and setsockopt(IPV6_RECVPKTINFO) calls by
gfe_quic::QuicSocketUtils::SetGetAddressInfo() calls. Update
gfe_quic::QuicSocketUtils::SetGetAddressInfo() to the best-known
implementation.

Merge internal CL: 70966702

R=rtenneti@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283482

[ramant (doing other things), 2014-07-15 23:02:39]

lgtm

https://codereview.chromium.org/397793004/diff/1/net/tools/quic/quic_server.cc
File net/tools/quic/quic_server.cc (right):

https://codereview.chromium.org/397793004/diff/1/net/tools/quic/quic_server.c...
net/tools/quic/quic_server.cc:101: int rc =
QuicSocketUtils::SetGetAddressInfo(fd_, address_family);
nit: do we need to call SetReceiveBufferSize and SetSendBufferSize first and
then call call QuicSocketUtils::SetGetAddressInfo? (don't exactly remember if
there is a dependency or not. jar may recall).

[wtc, 2014-07-16 01:09:22]

https://codereview.chromium.org/397793004/diff/1/net/tools/quic/quic_server.cc
File net/tools/quic/quic_server.cc (right):

https://codereview.chromium.org/397793004/diff/1/net/tools/quic/quic_server.c...
net/tools/quic/quic_server.cc:101: int rc =
QuicSocketUtils::SetGetAddressInfo(fd_, address_family);

On 2014/07/15 23:02:39, ramant wrote:
> nit: do we need to call SetReceiveBufferSize and SetSendBufferSize first and
> then call call QuicSocketUtils::SetGetAddressInfo?

I don't think these socket options depend on each other. We should be able to
set them in any order.

[wtc, 2014-07-16 01:09:29]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-07-16 01:11:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wtc@chromium.org/397793004/1

[commit-bot: I haz the power, 2014-07-16 09:54:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-16 20:23:17]

Change committed as 283482