chrome/browser/ui/sync/one_click_signin_helper_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

index 07a8af20fd2618d61e210ecc10889514ea2eed5a..924cea50166c1531e48e490a4e21f02825afcafb 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

@@ -633,7 +633,7 @@ TEST_F(OneClickSigninHelperTest, CanOfferDisabledByPolicy) {

// Simulate a policy disabling signin by writing kSigninAllowed directly.

profile()->GetTestingPrefService()->SetManagedPref(

- prefs::kSigninAllowed, base::Value::CreateBooleanValue(false));

+ prefs::kSigninAllowed, new base::FundamentalValue(false));

EXPECT_FALSE(OneClickSigninHelper::CanOffer(

web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,

@@ -641,11 +641,11 @@ TEST_F(OneClickSigninHelperTest, CanOfferDisabledByPolicy) {

// Reset the preference value to true.

profile()->GetTestingPrefService()->SetManagedPref(

- prefs::kSigninAllowed, base::Value::CreateBooleanValue(true));

+ prefs::kSigninAllowed, new base::FundamentalValue(true));

// Simulate a policy disabling sync by writing kSyncManaged directly.

profile()->GetTestingPrefService()->SetManagedPref(

- sync_driver::prefs::kSyncManaged, base::Value::CreateBooleanValue(true));

+ sync_driver::prefs::kSyncManaged, new base::FundamentalValue(true));

// Should still offer even if sync is disabled by policy.

EXPECT_TRUE(OneClickSigninHelper::CanOffer(

@@ -853,19 +853,19 @@ TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadDisabledByPolicy) {

// Simulate a policy disabling signin by writing kSigninAllowed directly.

// We should not offer to sign in the browser.

profile()->GetTestingPrefService()->SetManagedPref(

- prefs::kSigninAllowed, base::Value::CreateBooleanValue(false));

+ prefs::kSigninAllowed, new base::FundamentalValue(false));

EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,

OneClickSigninHelper::CanOfferOnIOThreadImpl(

valid_gaia_url_, &request_, io_data.get()));

// Reset the preference.

profile()->GetTestingPrefService()->SetManagedPref(

- prefs::kSigninAllowed, base::Value::CreateBooleanValue(true));

+ prefs::kSigninAllowed, new base::FundamentalValue(true));

// Simulate a policy disabling sync by writing kSyncManaged directly.

// We should still offer to sign in the browser.

profile()->GetTestingPrefService()->SetManagedPref(

- sync_driver::prefs::kSyncManaged, base::Value::CreateBooleanValue(true));

+ sync_driver::prefs::kSyncManaged, new base::FundamentalValue(true));

EXPECT_EQ(OneClickSigninHelper::CAN_OFFER,

OneClickSigninHelper::CanOfferOnIOThreadImpl(

valid_gaia_url_, &request_, io_data.get()));