Remove deprecated extension notifications from ProcessManager

Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead.

BUG=354046
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284366

[limasdf, 2014-07-17 16:04:23]

When you have time.

[Devlin, 2014-07-17 20:13:11]

lgtm

https://codereview.chromium.org/397743005/diff/20001/extensions/browser/proce...
File extensions/browser/process_manager.cc (right):

https://codereview.chromium.org/397743005/diff/20001/extensions/browser/proce...
extensions/browser/process_manager.cc:723: if (system->ready().is_signaled()) {
Let's go ahead and inline system here:
if (ExtensionSystem::Get(browser_context)->ready().is_signaled()) {
...
}

[limasdf, 2014-07-20 05:24:06]

The CQ bit was checked by limasdf@gmail.com

[limasdf, 2014-07-20 05:24:28]

https://codereview.chromium.org/397743005/diff/20001/extensions/browser/proce...
File extensions/browser/process_manager.cc (right):

https://codereview.chromium.org/397743005/diff/20001/extensions/browser/proce...
extensions/browser/process_manager.cc:723: if (system->ready().is_signaled()) {
On 2014/07/17 20:13:11, Devlin wrote:
> Let's go ahead and inline system here:
> if (ExtensionSystem::Get(browser_context)->ready().is_signaled()) {
> ...
> }

Done.

[commit-bot: I haz the power, 2014-07-20 05:24:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/limasdf@gmail.com/397743005/60001

[commit-bot: I haz the power, 2014-07-20 07:46:53]

Change committed as 284366

[tapted, 2014-07-21 01:56:24]

A revert of this CL has been created in
https://codereview.chromium.org/407883003/ by tapted@chromium.org.

The reason for reverting is: Suspected for Invalid Write / Unadressable /
Uninitialized errors in 
Linux Tests (valgrind)(3) via ProcessManagerTest.ProcessGrouping and others
starting 
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...

Errors like

Invalid write of size 8
 
ObserverListBase<autofill::PersonalDataManagerObserver>::AddObserver(autofill::PersonalDataManagerObserver*)
(base/observer_list.h:162)
 
autofill::PersonalDataManager::AddObserver(autofill::PersonalDataManagerObserver*)
(components/autofill/core/browser/personal_data_manager.cc:225)
  ...
  extensions::ProcessManagerTest::ProcessManagerTest()
(extensions/browser/process_manager_unittest.cc:39)

and a range of uninitialized reads/jumps..

[tapted, 2014-07-21 04:04:22]

Cycled green after the revert, in
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...

[James Cook, 2014-07-21 20:43:49]

On 2014/07/21 04:04:22, tapted wrote:
> Cycled green after the revert, in
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...

I think the problem is ExtensionTestBrowserClient is creating new
BrowserContextKeyedServices due to left-over BrowserContextKeyedServiceFactory
instances from earlier tests in the same binary.