Issue 397743003: Media Galleries: Another round of MTPDeviceDelegateImplLinux cleanup.

Issue 397743003: Media Galleries: Another round of MTPDeviceDelegateImplLinux cleanup. (Closed)

Created:
6 years, 5 months ago by Lei Zhang

Modified:
6 years, 5 months ago

Reviewers:
tommycli

CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Media Galleries: Another round of MTPDeviceDelegateImplLinux cleanup. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283362

Patch Set 2 : grammar #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
	M	chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc	View		7 chunks	+17 lines, -22 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

https://codereview.chromium.org/397743003/diff/1/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc File chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc (left): https://codereview.chromium.org/397743003/diff/1/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc#oldcode356 chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc:356: task_in_progress_ = true; There's only 1 caller and it ...

6 years, 5 months ago (2014-07-15 20:02:39 UTC) #1

tommycli

lgtm nice cleanups https://codereview.chromium.org/397743003/diff/1/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc File chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc (left): https://codereview.chromium.org/397743003/diff/1/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc#oldcode356 chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc:356: task_in_progress_ = true; On 2014/07/15 20:02:38, ...

6 years, 5 months ago (2014-07-15 21:11:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/397743003/20001

6 years, 5 months ago (2014-07-15 21:16:59 UTC) #4

Message was sent while issue was closed.

Change committed as 283362

Expand Messages | Collapse Messages