Source/wtf/PartitionAlloc.cpp - Issue 397733004: Allow assertions to be enabled in Blink Release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/PartitionAlloc.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/PartitionAlloc.cpp

diff --git a/Source/wtf/PartitionAlloc.cpp b/Source/wtf/PartitionAlloc.cpp

index 15c8286edef49b243c0d9d5658b9c32767d577ba..4348c2f3813a1f791bfccbc0e730a84460b2ca67 100644

--- a/Source/wtf/PartitionAlloc.cpp

+++ b/Source/wtf/PartitionAlloc.cpp

@@ -852,7 +852,7 @@ bool partitionReallocDirectMappedInPlace(PartitionRootGeneric* root, PartitionPa

setSystemPagesAccessible(charPtr + currentSize, recommitSize);

partitionRecommitSystemPages(root, charPtr + currentSize, recommitSize);

-#ifndef NDEBUG

+#if ENABLE(ASSERT)

memset(charPtr + currentSize, kUninitializedByte, recommitSize);

#endif

} else {

@@ -861,7 +861,7 @@ bool partitionReallocDirectMappedInPlace(PartitionRootGeneric* root, PartitionPa

return false;

}

-#ifndef NDEBUG

+#if ENABLE(ASSERT)

// Write a new trailing cookie.

partitionCookieWriteValue(charPtr + newSize - kCookieSize);

#endif

« no previous file with comments | « Source/wtf/PartitionAlloc.h ('k') | Source/wtf/PartitionAllocTest.cpp » ('j') | no next file with comments »