Source/core/animation/CompositorAnimationsTest.cpp - Issue 397733004: Allow assertions to be enabled in Blink Release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CompositorAnimationsTest.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/CompositorAnimationsTest.cpp

diff --git a/Source/core/animation/CompositorAnimationsTest.cpp b/Source/core/animation/CompositorAnimationsTest.cpp

index b4058b52173bc29c383f24fb13fae57ea834b7af..5f648882a052b400741208969f1c2d0d4efa17d4 100644

--- a/Source/core/animation/CompositorAnimationsTest.cpp

+++ b/Source/core/animation/CompositorAnimationsTest.cpp

@@ -340,9 +340,8 @@ TEST_F(AnimationCompositorAnimationsTest, ConvertTimingForCompositorIterationCou

m_timing.iterationCount = 5.5;

EXPECT_FALSE(convertTimingForCompositor(m_timing, m_compositorTiming));

- // Asserts will only trigger on DEBUG build.

// EXPECT_DEATH tests are flaky on Android.

-#if !defined(NDEBUG) && !OS(ANDROID)

+#if ENABLE(ASSERT) && !OS(ANDROID)

m_timing.iterationCount = -1;

EXPECT_DEATH(convertTimingForCompositor(m_timing, m_compositorTiming), "");

#endif

« no previous file with comments | « Source/core/accessibility/AXRenderObject.cpp ('k') | Source/core/css/CSSTokenizer-in.cpp » ('j') | no next file with comments »