Source/platform/heap/ThreadState.cpp - Issue 397733004: Allow assertions to be enabled in Blink Release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased after ENABLE(ASSERT) renaming. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/heap/ThreadState.cpp

diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp

index 2b2e003762748bea37f8b01520441206a18d8c72..fd02fa696f3541f8dceaf2f11c78594cef32627b 100644

--- a/Source/platform/heap/ThreadState.cpp

+++ b/Source/platform/heap/ThreadState.cpp

@@ -752,7 +752,7 @@ void ThreadState::setupHeapsForTermination()

BaseHeapPage* ThreadState::heapPageFromAddress(Address address)

{

BaseHeapPage* cachedPage = heapContainsCache()->lookup(address);

-#ifdef NDEBUG

+#if !ENABLE(ASSERT)

if (cachedPage)

return cachedPage;

#endif

@@ -779,7 +779,7 @@ BaseHeapPage* ThreadState::heapPageFromAddress(Address address)

void ThreadState::getStats(HeapStats& stats)

{

stats = m_stats;

-#ifndef NDEBUG

+#if ENABLE(ASSERT)

if (isConsistentForGC()) {

HeapStats scannedStats;

scannedStats.clear();