Source/core/css/parser/CSSPropertyParser.cpp - Issue 397733004: Allow assertions to be enabled in Blink Release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased after ENABLE(ASSERT) renaming. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index b1c38e7488cb82bd9722c130f1a38c4aa51d2e05..e8342b66d28753cc2eba26abe39a43bb628ec390 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -2631,7 +2631,7 @@ void CSSPropertyParser::parse3ValuesFillPosition(CSSParserValueList* valueList,

if (ident1 == CSSValueTop || ident1 == CSSValueBottom || swapNeeded)

value1.swap(value2);

-#ifndef NDEBUG

+#if ENABLE(ASSERT)

CSSPrimitiveValue* first = toCSSPrimitiveValue(value1.get());

CSSPrimitiveValue* second = toCSSPrimitiveValue(value2.get());

ident1 = first->getPairValue()->first()->getValueID();