Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Unified Diff: Source/modules/indexeddb/IDBRequest.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed config.gni. Minor cleanups. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBRequest.cpp
diff --git a/Source/modules/indexeddb/IDBRequest.cpp b/Source/modules/indexeddb/IDBRequest.cpp
index 16992b32ade0174816e1f35db0e4ff8a6bd849fd..79776879392b9c32e3fb1358c6c62aa96db355be 100644
--- a/Source/modules/indexeddb/IDBRequest.cpp
+++ b/Source/modules/indexeddb/IDBRequest.cpp
@@ -303,7 +303,7 @@ void IDBRequest::onSuccess(PassRefPtr<SharedBuffer> valueBuffer, PassOwnPtr<Vect
onSuccessInternal(IDBAny::create(valueBuffer, m_blobInfo.get()));
}
-#ifndef NDEBUG
+#if ENABLE(ASSERT)
static IDBObjectStore* effectiveObjectStore(IDBAny* source)
{
if (source->type() == IDBAny::IDBObjectStoreType)
@@ -322,7 +322,7 @@ void IDBRequest::onSuccess(PassRefPtr<SharedBuffer> prpValueBuffer, PassOwnPtr<V
if (!shouldEnqueueEvent())
return;
-#ifndef NDEBUG
+#if ENABLE(ASSERT)
jsbell 2014/07/16 00:03:16 Looks like we can remove this #if guard now?
Ken Russell (switch to Gerrit) 2014/07/16 00:05:46 Sure. Will remove in a subsequent version of this
ASSERT(keyPath == effectiveObjectStore(m_source)->metadata().keyPath);
#endif
@@ -331,7 +331,7 @@ void IDBRequest::onSuccess(PassRefPtr<SharedBuffer> prpValueBuffer, PassOwnPtr<V
ASSERT(!m_blobInfo.get());
m_blobInfo = blobInfo;
-#ifndef NDEBUG
+#if ENABLE(ASSERT)
assertPrimaryKeyValidOrInjectable(m_scriptState.get(), valueBuffer, m_blobInfo.get(), primaryKey, keyPath);
#endif

Powered by Google App Engine
This is Rietveld 408576698