Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp - Issue 397733004: Allow assertions to be enabled in Blink Release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed config.gni. Minor cleanups. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/EditCommand.h ('K') | « Source/core/rendering/compositing/CompositingInputsUpdater.cpp ('k') | Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp » ('j') | Source/modules/indexeddb/IDBRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp

diff --git a/Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp b/Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp

index 14770c3f37901db0c8673bbda6777ff2398e78b5..4a398d05fc45bae5c5f258f2d0ccf87f4c9bbd91 100644

--- a/Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp

+++ b/Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp

@@ -139,7 +139,7 @@ public:

static bool requiresCompositingOrSquashing(CompositingReasons reasons)

{

-#ifndef NDEBUG

+#if ENABLE(ASSERT)

bool fastAnswer = reasons != CompositingReasonNone;

bool slowAnswer = requiresCompositing(reasons) || requiresSquashing(reasons);

ASSERT(fastAnswer == slowAnswer);

@@ -283,7 +283,7 @@ void CompositingRequirementsUpdater::updateRecursive(RenderLayer* ancestorLayer,

childRecursionData.m_testingOverlap = true;

}

-#if ASSERT_ENABLED

+#if ENABLE(ASSERT)

LayerListMutationDetector mutationChecker(layer->stackingNode());

#endif