Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 397733004: Allow assertions to be enabled in Blink Release builds. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/fileapi/File.h ('k') | Source/core/html/parser/BackgroundHTMLInputStream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 scheduleOrPerformPostLayoutTasks(); 984 scheduleOrPerformPostLayoutTasks();
985 985
986 TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Layout", " endData", InspectorLayoutEvent::endData(rootForThisLayout)); 986 TRACE_EVENT_END1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Layout", " endData", InspectorLayoutEvent::endData(rootForThisLayout));
987 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeli ne migrates to tracing. 987 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeli ne migrates to tracing.
988 InspectorInstrumentation::didLayout(cookie, rootForThisLayout); 988 InspectorInstrumentation::didLayout(cookie, rootForThisLayout);
989 989
990 m_nestedLayoutCount--; 990 m_nestedLayoutCount--;
991 if (m_nestedLayoutCount) 991 if (m_nestedLayoutCount)
992 return; 992 return;
993 993
994 #ifndef NDEBUG 994 #if ENABLE(ASSERT)
995 // Post-layout assert that nobody was re-marked as needing layout during lay out. 995 // Post-layout assert that nobody was re-marked as needing layout during lay out.
996 document->renderView()->assertSubtreeIsLaidOut(); 996 document->renderView()->assertSubtreeIsLaidOut();
997 #endif 997 #endif
998 998
999 // FIXME: It should be not possible to remove the FrameView from the frame/p age during layout 999 // FIXME: It should be not possible to remove the FrameView from the frame/p age during layout
1000 // however m_inPerformLayout is not set for most of this function, so none o f our RELEASE_ASSERTS 1000 // however m_inPerformLayout is not set for most of this function, so none o f our RELEASE_ASSERTS
1001 // in LocalFrame/Page will fire. One of the post-layout tasks is disconnecti ng the LocalFrame from 1001 // in LocalFrame/Page will fire. One of the post-layout tasks is disconnecti ng the LocalFrame from
1002 // the page in fast/frames/crash-remove-iframe-during-object-beforeload-2.ht ml 1002 // the page in fast/frames/crash-remove-iframe-during-object-beforeload-2.ht ml
1003 // necessitating this check here. 1003 // necessitating this check here.
1004 // ASSERT(frame()->page()); 1004 // ASSERT(frame()->page());
(...skipping 1724 matching lines...) Expand 10 before | Expand all | Expand 10 after
2729 if (document->printing()) 2729 if (document->printing())
2730 m_paintBehavior |= PaintBehaviorFlattenCompositingLayers; 2730 m_paintBehavior |= PaintBehaviorFlattenCompositingLayers;
2731 2731
2732 ASSERT(!m_isPainting); 2732 ASSERT(!m_isPainting);
2733 m_isPainting = true; 2733 m_isPainting = true;
2734 2734
2735 // m_nodeToDraw is used to draw only one element (and its descendants) 2735 // m_nodeToDraw is used to draw only one element (and its descendants)
2736 RenderObject* renderer = m_nodeToDraw ? m_nodeToDraw->renderer() : 0; 2736 RenderObject* renderer = m_nodeToDraw ? m_nodeToDraw->renderer() : 0;
2737 RenderLayer* rootLayer = renderView->layer(); 2737 RenderLayer* rootLayer = renderView->layer();
2738 2738
2739 #ifndef NDEBUG 2739 #if ENABLE(ASSERT)
2740 renderView->assertSubtreeIsLaidOut(); 2740 renderView->assertSubtreeIsLaidOut();
2741 RenderObject::SetLayoutNeededForbiddenScope forbidSetNeedsLayout(*rootLayer- >renderer()); 2741 RenderObject::SetLayoutNeededForbiddenScope forbidSetNeedsLayout(*rootLayer- >renderer());
2742 #endif 2742 #endif
2743 2743
2744 rootLayer->paint(p, rect, m_paintBehavior, renderer); 2744 rootLayer->paint(p, rect, m_paintBehavior, renderer);
2745 2745
2746 if (rootLayer->containsDirtyOverlayScrollbars()) 2746 if (rootLayer->containsDirtyOverlayScrollbars())
2747 rootLayer->paintOverlayScrollbars(p, rect, m_paintBehavior, renderer); 2747 rootLayer->paintOverlayScrollbars(p, rect, m_paintBehavior, renderer);
2748 2748
2749 m_isPainting = false; 2749 m_isPainting = false;
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
2866 if (m_frame->document()->hasSVGFilterElementsRequiringLayerUpdate()) { 2866 if (m_frame->document()->hasSVGFilterElementsRequiringLayerUpdate()) {
2867 m_frame->document()->updateRenderTreeIfNeeded(); 2867 m_frame->document()->updateRenderTreeIfNeeded();
2868 2868
2869 if (needsLayout()) 2869 if (needsLayout())
2870 layout(); 2870 layout();
2871 } 2871 }
2872 2872
2873 // These asserts ensure that parent frames are clean, when child frames fini shed updating layout and style. 2873 // These asserts ensure that parent frames are clean, when child frames fini shed updating layout and style.
2874 ASSERT(!needsLayout()); 2874 ASSERT(!needsLayout());
2875 ASSERT(!m_frame->document()->hasSVGFilterElementsRequiringLayerUpdate()); 2875 ASSERT(!m_frame->document()->hasSVGFilterElementsRequiringLayerUpdate());
2876 #ifndef NDEBUG 2876 #if ENABLE(ASSERT)
2877 m_frame->document()->renderView()->assertRendererLaidOut(); 2877 m_frame->document()->renderView()->assertRendererLaidOut();
2878 #endif 2878 #endif
2879 2879
2880 } 2880 }
2881 2881
2882 void FrameView::invalidateTreeIfNeededRecursive() 2882 void FrameView::invalidateTreeIfNeededRecursive()
2883 { 2883 {
2884 // FIXME: We should be more aggressive at cutting tree traversals. 2884 // FIXME: We should be more aggressive at cutting tree traversals.
2885 invalidateTreeIfNeeded(); 2885 invalidateTreeIfNeeded();
2886 2886
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
3282 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3282 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3283 { 3283 {
3284 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3284 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3285 if (AXObjectCache* cache = axObjectCache()) { 3285 if (AXObjectCache* cache = axObjectCache()) {
3286 cache->remove(scrollbar); 3286 cache->remove(scrollbar);
3287 cache->handleScrollbarUpdate(this); 3287 cache->handleScrollbarUpdate(this);
3288 } 3288 }
3289 } 3289 }
3290 3290
3291 } // namespace WebCore 3291 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/fileapi/File.h ('k') | Source/core/html/parser/BackgroundHTMLInputStream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698