Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: mojo/shell/in_process_dynamic_service_runner.h

Issue 397733003: mojo: kill app_thread before unloading main app library and add tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: also service_manager_unittests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/desktop/mojo_main.cc ('k') | mojo/shell/in_process_dynamic_service_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/in_process_dynamic_service_runner.h
diff --git a/mojo/shell/in_process_dynamic_service_runner.h b/mojo/shell/in_process_dynamic_service_runner.h
index ce6b029c782d5a0c6295f0449f27e4ca5b1214b0..f1fc9b3fce1cb4dc2bf254e8e5bd61df74b9aac2 100644
--- a/mojo/shell/in_process_dynamic_service_runner.h
+++ b/mojo/shell/in_process_dynamic_service_runner.h
@@ -8,6 +8,7 @@
#include "base/callback.h"
#include "base/files/file_path.h"
#include "base/macros.h"
+#include "base/scoped_native_library.h"
#include "base/threading/simple_thread.h"
#include "mojo/shell/dynamic_service_runner.h"
#include "mojo/shell/keep_alive.h"
@@ -38,6 +39,7 @@ class InProcessDynamicServiceRunner
ScopedMessagePipeHandle service_handle_;
base::Callback<bool(void)> app_completed_callback_runner_;
+ base::ScopedNativeLibrary app_library_;
base::DelegateSimpleThread thread_;
DISALLOW_COPY_AND_ASSIGN(InProcessDynamicServiceRunner);
« no previous file with comments | « mojo/shell/desktop/mojo_main.cc ('k') | mojo/shell/in_process_dynamic_service_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698