Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 397723007: Use pass by reference in GridItemsSorter (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr., Manuel Rego, rune+blink, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use pass by reference in GridItemsSorter Use pass by reference here for efficiency. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/rendering/RenderGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-18 20:32:10 UTC) #1
adamk
lgtm
6 years, 5 months ago (2014-07-18 20:56:32 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-18 21:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/397723007/1
6 years, 5 months ago (2014-07-18 21:04:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 22:25:48 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 23:31:45 UTC) #6
Message was sent while issue was closed.
Change committed as 178495

Powered by Google App Engine
This is Rietveld 408576698