Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 397723006: Move RenderBlockFlow::constructTextRun out. (Closed)

Created:
6 years, 5 months ago by jbroman
Modified:
6 years, 5 months ago
CC:
blink-reviews, cbiesinger, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Move RenderBlockFlow::constructTextRun out. It doesn't need anything particular to block flows, and is used by other kinds of renderers. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -150 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/EllipsisBox.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderCombineText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 7 chunks +7 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderTextControl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/rendering/TextRunConstructor.h View 1 chunk +86 lines, -0 lines 0 comments Download
A Source/core/rendering/TextRunConstructor.cpp View 1 chunk +127 lines, -0 lines 0 comments Download
M Source/core/rendering/line/BreakingContextInlineHeaders.h View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
It's not clear why this lives in RenderBlockFlow as it is used all over core/rendering/. ...
6 years, 5 months ago (2014-07-18 13:38:42 UTC) #1
eae
LGTM
6 years, 5 months ago (2014-07-18 16:59:34 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-18 17:03:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/397723006/1
6 years, 5 months ago (2014-07-18 17:04:52 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 17:58:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 178467

Powered by Google App Engine
This is Rietveld 408576698