Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 397723004: Fix a minor test bug in test-webkitpy (Closed)

Created:
6 years, 5 months ago by Dirk Pranke
Modified:
6 years, 5 months ago
Reviewers:
eseidel
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix a minor test bug in test-webkitpy main_unittest was relying on the original sys.argv and passing that to the arg-parsing code. If somehow you had something in argv that wasn't a valid argument to test-webkitpy (e.g., by testing w/ unittest directly), the test would fail and raise SystemExit. This was an unnecessarily fragile design, so I fixed to preserve the original sys.argv and replace it for the test w/ something predictable. R=eseidel@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Tools/Scripts/webkitpy/test/main_unittest.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
6 years, 5 months ago (2014-07-17 21:25:04 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-07-18 18:52:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/397723004/1
6 years, 5 months ago (2014-07-18 18:52:49 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 20:10:50 UTC) #4
Message was sent while issue was closed.
Change committed as 178484

Powered by Google App Engine
This is Rietveld 408576698