Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 397723003: Omnibox: Don't Autocomplete Previously-Issued Search Queries (Closed)

Created:
6 years, 5 months ago by Mark P
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Project:
chromium
Visibility:
Public.

Description

Omnibox: Don't Autocomplete Previously-Issued Search Queries If I type an exact query that I issued before, SearchProvider shouldn't offer an extension to the autocompletion, even if that I issued that longer query more recently. This is counter to user's expectations: if I issued the query before and type it again and hit enter, I should get that query. I do not plan to bother running an experiment for this change. BUG=246411 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283836

Patch Set 1 #

Patch Set 2 : adds test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M chrome/browser/autocomplete/search_provider.cc View 3 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 1 chunk +27 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mark P
This is straightforward. Please tell me if you have any concerns. --mark
6 years, 5 months ago (2014-07-15 19:54:26 UTC) #1
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-15 21:36:06 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-15 21:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/397723003/20001
6 years, 5 months ago (2014-07-15 21:51:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 06:09:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 06:29:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171121)
6 years, 5 months ago (2014-07-16 06:29:09 UTC) #7
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-17 19:04:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/397723003/20001
6 years, 5 months ago (2014-07-17 19:11:53 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:18:57 UTC) #10
Message was sent while issue was closed.
Change committed as 283836

Powered by Google App Engine
This is Rietveld 408576698